From: sfjro@users.sourceforge.net
To: Thorsten Glaser <tg@mirbsd.de>
Cc: aufs-users@lists.sourceforge.net,
Debian kernel team <debian-kernel@lists.debian.org>,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt
Date: Mon, 02 Jan 2012 22:15:33 +0900 [thread overview]
Message-ID: <5487.1325510133@jrobl> (raw)
In-Reply-To: <Pine.BSM.4.64L.1201021027220.671@herc.mirbsd.org>
Thorsten Glaser:
> This doesn=E2=80=99t really differ from what I sent last,
> does it?
I am afraid you may not understand the important parts.
- the order of the definition and sched.h.
- no undef.
> >+#ifdef __KERNEL__
>
> Hrm. Is this needed?
Indeed necessary since aufs_name.h is exported to userspace.
> >+#define pr_fmt(fmt)=09AUFS_NAME " %s:%d:%s[%d]: " fmt,\
> >+=09=09__func__, __LINE__, current->comm, current->pid
>
> You need to #undef it first. It=E2=80=99s always defined, to just fmt.
No, I don't think undef is a good approach. The purpose of my patch, or
the difference from yours is to define pr_fmt first before all headers
including sched.h.
> >+#include <linux/aufs_name.h>
>
> You include aufs_name.h twice now, once in the Makefile,
> once in the header. Shouldn=E2=80=99t one be enough?
No, because aufs_type.h is exported to userspace.
J. R. Okajima
next prev parent reply other threads:[~2012-01-02 13:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 17:06 [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt Ben Hutchings
2011-12-31 4:46 ` sfjro
2011-12-31 8:01 ` Geert Uytterhoeven
2011-12-31 16:31 ` Thorsten Glaser
2012-01-02 2:58 ` sfjro
2012-01-02 3:40 ` Ben Hutchings
2012-01-02 4:01 ` sfjro
2012-01-02 2:04 ` sfjro
2011-12-31 22:18 ` Thorsten Glaser
2011-12-31 22:31 ` Thorsten Glaser
2012-01-01 1:15 ` Thorsten Glaser
2012-01-02 6:45 ` sfjro
2012-01-02 10:31 ` Thorsten Glaser
2012-01-02 13:15 ` sfjro [this message]
2012-01-02 13:30 ` Thorsten Glaser
2012-01-02 13:53 ` sfjro
2012-01-02 16:14 ` Thorsten Glaser
2012-01-02 16:53 ` sfjro
2012-01-02 17:36 ` Thorsten Glaser
2012-01-03 5:21 ` [PATCH 0/2] aufs: headers (Re: [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt) sfjro
2012-01-03 5:21 ` [PATCH 1/2] aufs: headers 1/2, bugfix, where the pr_fmt macro definition sfjro
2012-01-03 5:21 ` [PATCH 2/2] aufs: headers 2/2, simply refined sfjro
2011-12-31 22:55 ` [PATCH] aufs: Do not refer to AUFS_NAME in pr_fmt Thorsten Glaser
2012-01-01 8:47 ` Geert Uytterhoeven
2012-01-01 14:48 ` Thorsten Glaser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5487.1325510133@jrobl \
--to=sfjro@users.sourceforge.net \
--cc=aufs-users@lists.sourceforge.net \
--cc=debian-kernel@lists.debian.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tg@mirbsd.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.