diff for duplicates of <54870DEE.6050000@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 4b889c5..89a634a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,13 +10,13 @@ On 2014/12/6 21:52, Dan Carpenter wrote: > reason. Anyway I cleaned it up a bit. > > Fixes: ecf87b38d902 ('iommu/amd: Enhance AMD IR driver to suppport hierarchy irqdomain') -> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> > --- > Please review this carefully. I haven't tested it. Hi Dan, Thanks for fixing this leakage, it also makes code clearer. The strange code is wreckage of original code, should be cleaned up:) -Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com> +Reviewed-by: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c @@ -32,7 +32,7 @@ Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com> > - if (!data) > - goto out_free_parent; > - -> if (info->type = X86_IRQ_ALLOC_TYPE_IOAPIC) { +> if (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) { > if (get_irq_table(devid, true)) > index = info->ioapic_pin; > @@ -4223,7 +4218,6 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq, @@ -78,7 +78,7 @@ Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com> > kfree(irq_data->chip_data); > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in -> the body of a message to majordomo@vger.kernel.org +> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > diff --git a/a/content_digest b/N1/content_digest index 2580a4d..5d4cde1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020141206135257.GB17278@mwanda\0" - "From\0Jiang Liu <jiang.liu@linux.intel.com>\0" + "From\0Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" "Subject\0Re: [patch] iommu/amd: fix a small leak in irq_remapping_alloc()\0" - "Date\0Tue, 09 Dec 2014 14:57:50 +0000\0" + "Date\0Tue, 09 Dec 2014 22:57:50 +0800\0" "To\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>" " Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>\0" "Cc\0iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" @@ -21,13 +21,13 @@ "> reason. Anyway I cleaned it up a bit.\n" "> \n" "> Fixes: ecf87b38d902 ('iommu/amd: Enhance AMD IR driver to suppport hierarchy irqdomain')\n" - "> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\n" "> ---\n" "> Please review this carefully. I haven't tested it.\n" "Hi Dan,\n" "\tThanks for fixing this leakage, it also makes code clearer.\n" "The strange code is wreckage of original code, should be cleaned up:)\n" - "Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com>\n" + "Reviewed-by: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" "\n" "> \n" "> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c\n" @@ -43,7 +43,7 @@ "> -\tif (!data)\n" "> -\t\tgoto out_free_parent;\n" "> -\n" - "> \tif (info->type = X86_IRQ_ALLOC_TYPE_IOAPIC) {\n" + "> \tif (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) {\n" "> \t\tif (get_irq_table(devid, true))\n" "> \t\t\tindex = info->ioapic_pin;\n" "> @@ -4223,7 +4218,6 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,\n" @@ -89,9 +89,9 @@ "> \t\t\tkfree(irq_data->chip_data);\n" "> --\n" "> To unsubscribe from this list: send the line \"unsubscribe linux-kernel\" in\n" - "> the body of a message to majordomo@vger.kernel.org\n" + "> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" "> More majordomo info at http://vger.kernel.org/majordomo-info.html\n" "> Please read the FAQ at http://www.tux.org/lkml/\n" > -348fa29567f88b2118c825f9f8d03ea5955e136ea60914927a3470152549d1dc +91abfdc2a48d9270088041a90db63b38680c86e9c58f2945377af390b271a862
diff --git a/a/1.txt b/N2/1.txt index 4b889c5..a1b2ce8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -32,7 +32,7 @@ Reviewed-by: Jiang Liu <jiang.liu@linux.intel.com> > - if (!data) > - goto out_free_parent; > - -> if (info->type = X86_IRQ_ALLOC_TYPE_IOAPIC) { +> if (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) { > if (get_irq_table(devid, true)) > index = info->ioapic_pin; > @@ -4223,7 +4218,6 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq, diff --git a/a/content_digest b/N2/content_digest index 2580a4d..bff9562 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,12 +1,12 @@ "ref\020141206135257.GB17278@mwanda\0" "From\0Jiang Liu <jiang.liu@linux.intel.com>\0" "Subject\0Re: [patch] iommu/amd: fix a small leak in irq_remapping_alloc()\0" - "Date\0Tue, 09 Dec 2014 14:57:50 +0000\0" - "To\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>" - " Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>\0" - "Cc\0iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" + "Date\0Tue, 09 Dec 2014 22:57:50 +0800\0" + "To\0Dan Carpenter <dan.carpenter@oracle.com>" + " Joerg Roedel <joro@8bytes.org>\0" + "Cc\0iommu@lists.linux-foundation.org" + linux-kernel@vger.kernel.org + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On 2014/12/6 21:52, Dan Carpenter wrote:\n" @@ -43,7 +43,7 @@ "> -\tif (!data)\n" "> -\t\tgoto out_free_parent;\n" "> -\n" - "> \tif (info->type = X86_IRQ_ALLOC_TYPE_IOAPIC) {\n" + "> \tif (info->type == X86_IRQ_ALLOC_TYPE_IOAPIC) {\n" "> \t\tif (get_irq_table(devid, true))\n" "> \t\t\tindex = info->ioapic_pin;\n" "> @@ -4223,7 +4218,6 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,\n" @@ -94,4 +94,4 @@ "> Please read the FAQ at http://www.tux.org/lkml/\n" > -348fa29567f88b2118c825f9f8d03ea5955e136ea60914927a3470152549d1dc +0f6ebe536518c3896a142e4a254d831dc678a0e503e4abd6ea3fbab0f4cfca23
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.