Re: [PATCH 1/2] Btrfs: qgroup: free reserved in exceeding quota.

[Josef Bacik <jbacik@fb.com>]

On 12/09/2014 06:27 AM, Dongsheng Yang wrote:
> When we exceed quota limit in writing, we will free
> some reserved extent when we need to drop but not free
> account in qgroup. It means, each time we exceed quota
> in writing, there will be some remain space in qg->reserved
> we can not use any more. If things go on like this, the
> all space will be ate up.
>
> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
> ---
>   fs/btrfs/extent-tree.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index a84e00d..014b7f2 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -5262,8 +5262,11 @@ out_fail:
>   			to_free = 0;
>   	}
>   	spin_unlock(&BTRFS_I(inode)->lock);
> -	if (dropped)
> +	if (dropped) {
> +		if (root->fs_info->quota_enabled)
> +			btrfs_qgroup_free(root, dropped * root->nodesize);

This needs to be num_bytes + dropped * root->nodesize.  Thanks,

Josef