From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyMww-0005zT-Ge for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:43:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyMwq-0005jF-F9 for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:43:42 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:33216 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyMwq-0005iN-4G for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:43:36 -0500 Message-ID: <548718A2.5030002@kamp.de> Date: Tue, 09 Dec 2014 16:43:30 +0100 From: Peter Lieven MIME-Version: 1.0 References: <1417780229-6930-1-git-send-email-pl@kamp.de> <1417780229-6930-2-git-send-email-pl@kamp.de> <5481C830.2060403@redhat.com> In-Reply-To: <5481C830.2060403@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V2 1/4] block: add accounting for merged requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com On 05.12.2014 15:58, Eric Blake wrote: > On 12/05/2014 04:50 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> block.c | 2 ++ >> block/accounting.c | 7 +++++++ >> block/qapi.c | 2 ++ >> hmp.c | 6 +++++- >> include/block/accounting.h | 3 +++ >> qapi/block-core.json | 9 ++++++++- >> qmp-commands.hx | 22 ++++++++++++++++++---- >> 7 files changed, 45 insertions(+), 6 deletions(-) >> @@ -2284,6 +2288,8 @@ Example: >> "rd_total_times_ns":3465673657 >> "flush_total_times_ns":49653 >> "flush_operations":61, >> + "rd_merged":0, >> + "wr_merged":0 > Oh my - we previously had invalid JSON in our example. Yay that this > fixes it :) There is actually more invalid JSON, but I would fix that in a separate patch apart from this series. Peter