From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dnsmasq: let init script cleanup stale pidfile
Date: Tue, 09 Dec 2014 17:04:00 -0300 [thread overview]
Message-ID: <548755B0.6020002@zacarias.com.ar> (raw)
In-Reply-To: <1416068836-4053-1-git-send-email-jkrause@posteo.de>
On 11/15/2014 01:27 PM, J?rg Krause wrote:
> dnsmasq does not clean up its pidfile after termination. Do this manually.
>
> Supersedes: [PATCH 1/1] package/dnsmasq: cleanup run-time files in init script
> https://patchwork.ozlabs.org/patch/411015/
Hi.
Does it fix anything in particular other than looks?
Looking at the dnsmasq source it does an unlink() on successful
startup/fork so any previous pidfile doesn't bother it at all.
I was about to say "i'd like to see the start-stop-daemon invocation
changed" but then i realized that it doesn't remove the pidfile either,
so basically any "start-stop-daemon -K -q -x" in any initscript
"suffers" from this "problem".
So even if the pidfile is on permanent storage i don't see how this can
cause issues.
Regards.
next prev parent reply other threads:[~2014-12-09 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-15 16:27 [Buildroot] [PATCH 1/1] package/dnsmasq: let init script cleanup stale pidfile Jörg Krause
2014-12-09 20:04 ` Gustavo Zacarias [this message]
2014-12-09 21:35 ` Jörg Krause
2014-12-09 21:48 ` Gustavo Zacarias
2014-12-09 21:58 ` Jörg Krause
2014-12-10 20:56 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548755B0.6020002@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.