From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jincheng Miao Subject: Re: [PATCH] igb_uio: kernel version check for using kstrtoul or strict_strtoul Date: Wed, 10 Dec 2014 10:54:57 +0800 Message-ID: <5487B601.20305@redhat.com> References: <1418179099-4822-1-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Helin Zhang , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1418179099-4822-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Here is my patch for it, and it also resolves issue of pci_num_vf() definition. And I will send V3 for a while. On 12/10/2014 10:38 AM, Helin Zhang wrote: > strict_strtoul() was just a redefinition of kstrtoul() for a long > time. From kernel version of 3.18, strict_strtoul() will not be > defined at all. A compile time kernel version check is needed to > decide which function or macro can be used for a specific version > of kernel. > > Signed-off-by: Helin Zhang > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index d1ca26e..2fcc5f4 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -83,7 +83,11 @@ store_max_vfs(struct device *dev, struct device_attribute *attr, > unsigned long max_vfs; > struct pci_dev *pdev = container_of(dev, struct pci_dev, dev); > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 2, 0) > if (0 != strict_strtoul(buf, 0, &max_vfs)) > +#else > + if (0 != kstrtoul(buf, 0, &max_vfs)) > +#endif > return -EINVAL; > > if (0 == max_vfs)