From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XycOP-0004cW-Nw for qemu-devel@nongnu.org; Wed, 10 Dec 2014 03:13:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XycOJ-00085Y-LB for qemu-devel@nongnu.org; Wed, 10 Dec 2014 03:13:05 -0500 Received: from relay.parallels.com ([195.214.232.42]:39029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XycOJ-0007wf-Cr for qemu-devel@nongnu.org; Wed, 10 Dec 2014 03:12:59 -0500 Message-ID: <5488004B.7050302@parallels.com> Date: Wed, 10 Dec 2014 11:11:55 +0300 From: Vladimir Sementsov-Ogievskiy MIME-Version: 1.0 References: <1417465816-19345-1-git-send-email-jsnow@redhat.com> <1417465816-19345-6-git-send-email-jsnow@redhat.com> In-Reply-To: <1417465816-19345-6-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com about naming: We will need functions for set/unset a subregion of BdrvDirtyBitmap, to fix migration and mirror (accordingly to my "[PATCH v2] block: fix spoiling all dirty bitmaps by mirror and migration"). Having the function 'bdrv_reset_dirty_bitmap' from this patch, we'll have to add functions like bdrv_set_dirty_bitmap_region and bdrv_reset_dirty_bitmap_region But, may be, it is more consistent to have bdrv_set_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, uint64_t start, uint64_t count) bdrv_reset_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, uint64_t start, uint64_t count) for more transparent access to underlaying hbitmap interface? And then, name the considered function like 'bdrv_clear_dirty_bitmap'? Best regards, Vladimir On 01.12.2014 23:30, John Snow wrote: > bdrv_reset_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap)