From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Xyd5x-00006W-Cv for mharc-qemu-trivial@gnu.org; Wed, 10 Dec 2014 03:58:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyd5p-0008Px-E7 for qemu-trivial@nongnu.org; Wed, 10 Dec 2014 03:58:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xyd5j-00085M-2d for qemu-trivial@nongnu.org; Wed, 10 Dec 2014 03:57:57 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:37594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyd5W-00080d-CY; Wed, 10 Dec 2014 03:57:38 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id EFFB8419BC; Wed, 10 Dec 2014 11:57:36 +0300 (MSK) Message-ID: <54880B00.3030108@msgid.tls.msk.ru> Date: Wed, 10 Dec 2014 11:57:36 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: zhanghailiang , qemu-trivial@nongnu.org References: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: sw@weilnetz.de, armbru@redhat.com, qemu-devel@nongnu.org, Paolo Bonzini , peter.huangpeng@huawei.com, afaerber@suse.de Subject: Re: [Qemu-trivial] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 08:58:03 -0000 09.12.2014 10:15, zhanghailiang wrote: > Refactor superio_ioport_writeb to fix the out of bounds write warning. Is it just a warning, or real oob write? >From the code it looks like it's just a warning... [] > + > + } > + if (can_write == true) { 09.12.2014 17:08, Paolo Bonzini wrote: > Michael, can you remove "== true" when applying this patch? Sure, just did. Does it mean I can add your R-b too? ;) Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyd5c-0008JR-NA for qemu-devel@nongnu.org; Wed, 10 Dec 2014 03:57:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xyd5W-000814-Jf for qemu-devel@nongnu.org; Wed, 10 Dec 2014 03:57:44 -0500 Message-ID: <54880B00.3030108@msgid.tls.msk.ru> Date: Wed, 10 Dec 2014 11:57:36 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1418109359-2364-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] vt82c686: fix coverity warning about out-of-bounds write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-trivial@nongnu.org Cc: sw@weilnetz.de, armbru@redhat.com, qemu-devel@nongnu.org, Paolo Bonzini , peter.huangpeng@huawei.com, afaerber@suse.de 09.12.2014 10:15, zhanghailiang wrote: > Refactor superio_ioport_writeb to fix the out of bounds write warning. Is it just a warning, or real oob write? >>From the code it looks like it's just a warning... [] > + > + } > + if (can_write == true) { 09.12.2014 17:08, Paolo Bonzini wrote: > Michael, can you remove "== true" when applying this patch? Sure, just did. Does it mean I can add your R-b too? ;) Thanks, /mjt