All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Vasilyev <pavel@pavlinux.ru>
To: chase.qi@linaro.org, linux-rt-users@vger.kernel.org
Cc: clark.williams@gmail.com, milosz.wasilewski@linaro.org,
	naresh.kamboju@linaro.org, jorge.ramirez-ortiz@linaro.org,
	anders.roxell@linaro.org, mike.holmes@linaro.org
Subject: Re: [PATCH] pip_stress: increase usleep for ARM devices
Date: Wed, 10 Dec 2014 13:00:54 +0300	[thread overview]
Message-ID: <548819D6.3060507@pavlinux.ru> (raw)
In-Reply-To: <1418199901-3175-1-git-send-email-chase.qi@linaro.org>

May be #defines?

#ifndef (ARM)
		usleep(500);
#else
		usleep(3500);
#endif


10.12.2014 11:25, chase.qi@linaro.org пишет:
> From: Chase Qi <chase.qi@linaro.org>
>
> Hello,
>
> pip_stress works out of the box on my x86 based laptop, but
> doesn't work on ARM devices, returned 'no inversion incurred'.
> Follow the comment to increase usleep value, 2500 worked for
> pandaboard and 3000 worked for Beaglebone Black board.
>
> I propose that increase the usleep value to 3500 from upstream,
> so that we can use pip_stress right out of the box.
>
> Please let me know if this is acceptable.
>
> Regards,
> Chase
>
> Signed-off-by: Chase Qi <chase.qi@linaro.org>
> ---
>   src/pi_tests/pip_stress.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pi_tests/pip_stress.c b/src/pi_tests/pip_stress.c
> index 2b42b8f..553290b 100644
> --- a/src/pi_tests/pip_stress.c
> +++ b/src/pi_tests/pip_stress.c
> @@ -162,7 +162,7 @@ void low(pid_t pid)
>   				statep->inversion = 0;
>   			}
>   		Pthread_mutex_unlock(statep->mutex);
> -		usleep(500);
> +		usleep(3500);
>   	Pthread_mutex_unlock(resource);
>   	waitpid(pid, &status, 0);
>   }
>


-- 

                                                          Pavel.
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-12-10 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  8:25 [PATCH] pip_stress: increase usleep for ARM devices chase.qi
2014-12-10 10:00 ` Pavel Vasilyev [this message]
2014-12-10 14:15 ` Jorge Ramirez-Ortiz
2014-12-10 21:16   ` Clark Williams
2015-01-15 18:44     ` Clark Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548819D6.3060507@pavlinux.ru \
    --to=pavel@pavlinux.ru \
    --cc=anders.roxell@linaro.org \
    --cc=chase.qi@linaro.org \
    --cc=clark.williams@gmail.com \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mike.holmes@linaro.org \
    --cc=milosz.wasilewski@linaro.org \
    --cc=naresh.kamboju@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.