From: Akira Hayakawa <ruby.wktk@gmail.com>
To: ejt@redhat.com
Cc: dm-devel@redhat.com, gregkh@linuxfoundation.org,
snitzer@redhat.com, agk@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH] staging: writeboost: Add dm-writeboost
Date: Wed, 10 Dec 2014 23:43:46 +0900 [thread overview]
Message-ID: <54885C22.3030808@gmail.com> (raw)
In-Reply-To: <20141210134223.GE21108@debian>
On 12/10/14 10:42 PM, Joe Thornber wrote:
> On Wed, Dec 10, 2014 at 10:31:31PM +0900, Akira Hayakawa wrote:
>> Joe,
>>
>>> So you copy the bio payload to a different block of ram and then
>>> complete the bio? Or does the rambuf refer to the bio payload
>>> directly?
>> Good question.
>> The answer is, copy the data (got by bio_data(bio)) to rambuf once
>> and ack if it's not barrier things.
>> It would be nice if data in rambuf points to bio payload but it now copies
>> because bio payload can be reused after completion. Am I right?
>> Is there a way of eliminate memory copying?
>
> You *have* to eliminate this memory copying. Remap the bios to the
> relevant portion of your log, and don't complete them until you log
> chunk is coherent.
>
Barrier writes don't ack until the log is written on cache device.
I guess treating other writes as well will do this work.
But, it will be much better if I can do this by manipulating reference count
of the bio payload. I am not sure how the implementation would be.
Anyway, thanks for advice,
- Akira
next prev parent reply other threads:[~2014-12-10 14:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-07 12:35 [PATCH] staging: writeboost: Add dm-writeboost Akira Hayakawa
2014-12-07 20:08 ` Greg KH
2014-12-07 21:04 ` Akira Hayakawa
2014-12-09 15:12 ` [dm-devel] " Joe Thornber
2014-12-09 15:48 ` Mike Snitzer
2014-12-10 10:21 ` Akira Hayakawa
2014-12-10 10:00 ` [dm-devel] [PATCH] " Joe Thornber
2014-12-10 11:00 ` Akira Hayakawa
2014-12-10 11:22 ` Joe Thornber
2014-12-10 12:33 ` Joe Thornber
2014-12-10 12:59 ` Akira Hayakawa
2014-12-10 13:13 ` Joe Thornber
2014-12-10 13:31 ` Akira Hayakawa
2014-12-10 13:42 ` Joe Thornber
2014-12-10 14:43 ` Akira Hayakawa [this message]
2014-12-12 12:51 ` Marian Csontos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54885C22.3030808@gmail.com \
--to=ruby.wktk@gmail.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ejt@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.