From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XykOO-0007eA-EU for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:45:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XykOI-0006Fo-1r for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:45:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XykOH-0006FQ-Qo for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:45:29 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBAGjTkQ006805 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 10 Dec 2014 11:45:29 -0500 Message-ID: <548878A5.9020203@redhat.com> Date: Wed, 10 Dec 2014 17:45:25 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418209592-9373-1-git-send-email-pbonzini@redhat.com> <1418209592-9373-2-git-send-email-pbonzini@redhat.com> <20141210131246.GL5002@thinpad.lan.raisama.net> <548861F6.1010802@redhat.com> <20141210154823.GM5002@thinpad.lan.raisama.net> In-Reply-To: <20141210154823.GM5002@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] pc: add 2.3 machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 10/12/2014 16:48, Eduardo Habkost wrote: > Whatever you see on pc_q35.c, it is also present on pc_piix.c: > > #define PC_I440FX_2_0_MACHINE_OPTIONS PC_I440FX_2_1_MACHINE_OPTIONS > > Both approaches are OK to me, I just don't see why you decided to make > pc_piix.c and pc_q35.c different. Because I didn't notice it in pc_piix.c. I'll change to #define PC_I440FX_2_2_MACHINE_OPTIONS PC_I440FX_2_3_MACHINE_OPTIONS Thanks, and sorry for the confusion. Paolo