From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v3 14/28] eal/pci: Add rte_eal_devargs_remove Date: Thu, 11 Dec 2014 10:40:34 +0900 Message-ID: <5488F612.5010909@igel.co.jp> References: <1416474399-16851-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-1-git-send-email-mukawa@igel.co.jp> <1418106629-22227-15-git-send-email-mukawa@igel.co.jp> <533710CFB86FA344BFBF2D6802E60286C9E22F@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "nakajima.yoshihiro-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "masutani.hitoshi-Zyj7fXuS5i5L9jVzuh4AOg@public.gmane.org" , "menrigh-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org" To: "Qiu, Michael" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9E22F-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Michael, (2014/12/10 0:36), Qiu, Michael wrote: > I don't know if other reviewers ask you to split so many patches. But I= > would like merge some of them, because some are doing same affairs(just= > using different args), others should be add/remove affairs. Those could= > be merge to one patch, although it is much more easier for review. > > Actually, it is much harder to review such long thread.... I am sorry for that. I will merge some patches into one. Also appreciate your other comments. I will fix my code like your suggestions, and submit it again. Thanks, Tetsuya > But just one suggestion, merge or not depends you. > > Thanks, > Michael > On 2014/12/9 14:33, Tetsuya Mukawa wrote: >> The function removes a specified devargs from devargs_list. >> >> Signed-off-by: Tetsuya Mukawa >> --- >> lib/librte_eal/common/eal_common_devargs.c | 16 ++++++++++++++++ >> lib/librte_eal/common/include/rte_devargs.h | 18 ++++++++++++++++++ >> 2 files changed, 34 insertions(+) >> >> diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_e= al/common/eal_common_devargs.c >> index f95a12d..5fd2a2c 100644 >> --- a/lib/librte_eal/common/eal_common_devargs.c >> +++ b/lib/librte_eal/common/eal_common_devargs.c >> @@ -140,6 +140,22 @@ rte_eal_devargs_add(enum rte_devtype devtype, con= st char *devargs_str) >> return 0; >> } >> =20 >> +/* remove it from the devargs_list */ >> +void >> +rte_eal_devargs_remove(enum rte_devtype devtype, void *args) >> +{ >> + struct rte_devargs *devargs; >> + >> + if (args =3D=3D NULL) >> + return; >> + >> + devargs =3D rte_eal_devargs_find(devtype, args); >> + if (devargs =3D=3D NULL) >> + return; >> + >> + TAILQ_REMOVE(&devargs_list, devargs, next); >> +} >> + >> /* count the number of devices of a specified type */ >> unsigned int >> rte_eal_devargs_type_count(enum rte_devtype devtype) >> diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_= eal/common/include/rte_devargs.h >> index 9f9c98f..1066efd 100644 >> --- a/lib/librte_eal/common/include/rte_devargs.h >> +++ b/lib/librte_eal/common/include/rte_devargs.h >> @@ -123,6 +123,24 @@ extern struct rte_devargs_list devargs_list; >> int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs= _str); >> =20 >> /** >> + * Remove a device from the user device list >> + * >> + * For PCI devices, the format of arguments string is "PCI_ADDR". It = shouldn't >> + * involves parameters for the device. Example: "08:00.1". >> + * >> + * For virtual devices, the format of arguments string is "DRIVER_NAM= E*". It >> + * shouldn't involves parameters for the device. Example: "eth_ring".= The >> + * validity of the driver name is not checked by this function, it is= done >> + * when closing the drivers. >> + * >> + * @param devtype >> + * The type of the device. >> + * @param name >> + * The name of the device. >> + */ >> +void rte_eal_devargs_remove(enum rte_devtype devtype, void *args); >> + >> +/** >> * Count the number of user devices of a specified type >> * >> * @param devtype