From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5488FF63.8020609@lab.ntt.co.jp> Date: Thu, 11 Dec 2014 11:20:19 +0900 From: Toshiaki Makita MIME-Version: 1.0 References: <1418179394-4470-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20141210.145047.1148744559031706340.davem@davemloft.net> <5488FBBC.2050105@lab.ntt.co.jp> <20141210.211306.1331714594864472914.davem@davemloft.net> In-Reply-To: <20141210.211306.1331714594864472914.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] bridge: Add ability to always enable TSO/UFO List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org On 2014/12/11 11:13, David Miller wrote: > From: Toshiaki Makita > Date: Thu, 11 Dec 2014 11:04:44 +0900 > >> On 2014/12/11 4:50, David Miller wrote: >>> From: Toshiaki Makita >>> Date: Wed, 10 Dec 2014 11:43:14 +0900 >>> >>>> - features &= ~NETIF_F_ONE_FOR_ALL; >>>> + features &= ~NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE; >>> >>> I don't think this is the expression you intend to use. >> >> Thank you, but this is really my intended expression. >> >> "features &= ~NETIF_F_ONE_FOR_ALL" drops all of ONE_FOR_ALL bits >> including GSO_SOFTWARE. >> But I want to leave GSO_SOFTWARE bits here. > > It is clearer to say this as: > > ~(NETIF_F_ONE_FOR_ALL & ~NETIF_F_GSO_SOFTWARE) > > Or create a new NETIF_F_* macro to express this idea succinctly. OK, I will. (once net-next is reopened) Thanks, Toshiaki Makita From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH net-next] bridge: Add ability to always enable TSO/UFO Date: Thu, 11 Dec 2014 11:20:19 +0900 Message-ID: <5488FF63.8020609@lab.ntt.co.jp> References: <1418179394-4470-2-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20141210.145047.1148744559031706340.davem@davemloft.net> <5488FBBC.2050105@lab.ntt.co.jp> <20141210.211306.1331714594864472914.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: David Miller Return-path: In-Reply-To: <20141210.211306.1331714594864472914.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 2014/12/11 11:13, David Miller wrote: > From: Toshiaki Makita > Date: Thu, 11 Dec 2014 11:04:44 +0900 > >> On 2014/12/11 4:50, David Miller wrote: >>> From: Toshiaki Makita >>> Date: Wed, 10 Dec 2014 11:43:14 +0900 >>> >>>> - features &= ~NETIF_F_ONE_FOR_ALL; >>>> + features &= ~NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE; >>> >>> I don't think this is the expression you intend to use. >> >> Thank you, but this is really my intended expression. >> >> "features &= ~NETIF_F_ONE_FOR_ALL" drops all of ONE_FOR_ALL bits >> including GSO_SOFTWARE. >> But I want to leave GSO_SOFTWARE bits here. > > It is clearer to say this as: > > ~(NETIF_F_ONE_FOR_ALL & ~NETIF_F_GSO_SOFTWARE) > > Or create a new NETIF_F_* macro to express this idea succinctly. OK, I will. (once net-next is reopened) Thanks, Toshiaki Makita