From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying.Liu@freescale.com (Liu Ying) Date: Thu, 11 Dec 2014 10:52:45 +0800 Subject: [PATCH RFC 04/15] drm/dsi: Do not add DSI devices for the child nodes with input-port property In-Reply-To: <20141210122105.GC23558@ulmo.nvidia.com> References: <1418200648-32656-1-git-send-email-Ying.Liu@freescale.com> <1418200648-32656-5-git-send-email-Ying.Liu@freescale.com> <20141210122105.GC23558@ulmo.nvidia.com> Message-ID: <548906FD.5070009@freescale.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thierry, On 12/10/2014 08:21 PM, Thierry Reding wrote: > On Wed, Dec 10, 2014 at 04:37:17PM +0800, Liu Ying wrote: >> The MIPI DSI bus driver would try to add a DSI device for a host's every >> child node which contains the reg property. Unfortunately, the existing >> i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg > > There aren't any existing nodes for the DSI host on i.MX. This patch > series adds support for them. There are existing nodes for the DSI host node. Please find them in arch/arm/boot/dts/imx6qdl.dtsi and arch/arm/boot/dts/imx6q.dts. The DSI host node contains two child nodes for i.MX6DL and another two for i.MX6Q. Each child node has a reg property embedded. > >> property, but the child nodes are ports pointing to dedicated CRTCs. >> So, this patch phases out the child nodes with input-port property before >> adding DSI devices for them and updates the MIPI DSI bus OF binding >> documentation. >> >> Signed-off-by: Liu Ying >> --- >> Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ >> drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) > > Sorry, but NAK. There's no need for this special-case. I'll go into more > detail in response to patch 09/15. Thanks for reviewing the patches. Any idea how to handle the special case? The existing child nodes for the DSI host node do have the reg properties embedded. Regards, Liu Ying > > Thierry > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liu Ying Subject: Re: [PATCH RFC 04/15] drm/dsi: Do not add DSI devices for the child nodes with input-port property Date: Thu, 11 Dec 2014 10:52:45 +0800 Message-ID: <548906FD.5070009@freescale.com> References: <1418200648-32656-1-git-send-email-Ying.Liu@freescale.com> <1418200648-32656-5-git-send-email-Ying.Liu@freescale.com> <20141210122105.GC23558@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20141210122105.GC23558@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: devicetree@vger.kernel.org, linux@arm.linux.org.uk, kernel@pengutronix.de, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mturquette@linaro.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgVGhpZXJyeSwKCk9uIDEyLzEwLzIwMTQgMDg6MjEgUE0sIFRoaWVycnkgUmVkaW5nIHdyb3Rl Ogo+IE9uIFdlZCwgRGVjIDEwLCAyMDE0IGF0IDA0OjM3OjE3UE0gKzA4MDAsIExpdSBZaW5nIHdy b3RlOgo+PiBUaGUgTUlQSSBEU0kgYnVzIGRyaXZlciB3b3VsZCB0cnkgdG8gYWRkIGEgRFNJIGRl dmljZSBmb3IgYSBob3N0J3MgZXZlcnkKPj4gY2hpbGQgbm9kZSB3aGljaCBjb250YWlucyB0aGUg cmVnIHByb3BlcnR5LiAgVW5mb3J0dW5hdGVseSwgdGhlIGV4aXN0aW5nCj4+IGkuTVg2US9TREwg TUlQSSBEU0kgaG9zdCBkZXZpY2UgdHJlZSBub2RlJ3MgY2hpbGQgbm9kZXMgY29udGFpbiB0aGUg cmVnCj4KPiBUaGVyZSBhcmVuJ3QgYW55IGV4aXN0aW5nIG5vZGVzIGZvciB0aGUgRFNJIGhvc3Qg b24gaS5NWC4gVGhpcyBwYXRjaAo+IHNlcmllcyBhZGRzIHN1cHBvcnQgZm9yIHRoZW0uCgpUaGVy ZSBhcmUgZXhpc3Rpbmcgbm9kZXMgZm9yIHRoZSBEU0kgaG9zdCBub2RlLiBQbGVhc2UgZmluZCB0 aGVtIGluIAphcmNoL2FybS9ib290L2R0cy9pbXg2cWRsLmR0c2kgYW5kIGFyY2gvYXJtL2Jvb3Qv ZHRzL2lteDZxLmR0cy4gVGhlIERTSSAKaG9zdCBub2RlIGNvbnRhaW5zIHR3byBjaGlsZCBub2Rl cyBmb3IgaS5NWDZETCBhbmQgYW5vdGhlciB0d28gZm9yIAppLk1YNlEuICBFYWNoIGNoaWxkIG5v ZGUgaGFzIGEgcmVnIHByb3BlcnR5IGVtYmVkZGVkLgoKPgo+PiBwcm9wZXJ0eSwgYnV0IHRoZSBj aGlsZCBub2RlcyBhcmUgcG9ydHMgcG9pbnRpbmcgdG8gZGVkaWNhdGVkIENSVENzLgo+PiBTbywg dGhpcyBwYXRjaCBwaGFzZXMgb3V0IHRoZSBjaGlsZCBub2RlcyB3aXRoIGlucHV0LXBvcnQgcHJv cGVydHkgYmVmb3JlCj4+IGFkZGluZyBEU0kgZGV2aWNlcyBmb3IgdGhlbSBhbmQgdXBkYXRlcyB0 aGUgTUlQSSBEU0kgYnVzIE9GIGJpbmRpbmcKPj4gZG9jdW1lbnRhdGlvbi4KPj4KPj4gU2lnbmVk LW9mZi1ieTogTGl1IFlpbmcgPFlpbmcuTGl1QGZyZWVzY2FsZS5jb20+Cj4+IC0tLQo+PiAgIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9taXBpL2RzaS9taXBpLWRzaS1idXMudHh0 IHwgNCArKysrCj4+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgfCA1ICsrKy0tCj4+ICAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBTb3JyeSwgYnV0IE5BSy4gVGhlcmUncyBubyBu ZWVkIGZvciB0aGlzIHNwZWNpYWwtY2FzZS4gSSdsbCBnbyBpbnRvIG1vcmUKPiBkZXRhaWwgaW4g cmVzcG9uc2UgdG8gcGF0Y2ggMDkvMTUuCgpUaGFua3MgZm9yIHJldmlld2luZyB0aGUgcGF0Y2hl cy4KCkFueSBpZGVhIGhvdyB0byBoYW5kbGUgdGhlIHNwZWNpYWwgY2FzZT8gIFRoZSBleGlzdGlu ZyBjaGlsZCBub2RlcyBmb3IgCnRoZSBEU0kgaG9zdCBub2RlIGRvIGhhdmUgdGhlIHJlZyBwcm9w ZXJ0aWVzIGVtYmVkZGVkLgoKUmVnYXJkcywKCkxpdSBZaW5nCgo+Cj4gVGhpZXJyeQo+Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933653AbaLKCse (ORCPT ); Wed, 10 Dec 2014 21:48:34 -0500 Received: from mail-by2on0125.outbound.protection.outlook.com ([207.46.100.125]:35132 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933176AbaLKCsd (ORCPT ); Wed, 10 Dec 2014 21:48:33 -0500 Message-ID: <548906FD.5070009@freescale.com> Date: Thu, 11 Dec 2014 10:52:45 +0800 From: Liu Ying User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , , , , , , Subject: Re: [PATCH RFC 04/15] drm/dsi: Do not add DSI devices for the child nodes with input-port property References: <1418200648-32656-1-git-send-email-Ying.Liu@freescale.com> <1418200648-32656-5-git-send-email-Ying.Liu@freescale.com> <20141210122105.GC23558@ulmo.nvidia.com> In-Reply-To: <20141210122105.GC23558@ulmo.nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=Ying.Liu@freescale.com; X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(199003)(189002)(377454003)(479174003)(51704005)(52604005)(65816999)(64706001)(120916001)(50986999)(23746002)(110136001)(50466002)(68736005)(62966003)(99396003)(87936001)(20776003)(47776003)(87266999)(59896002)(77156002)(85426001)(4396001)(84676001)(31966008)(92566001)(65806001)(65956001)(77096005)(104016003)(46102003)(33656002)(86362001)(19580395003)(21056001)(97736003)(106466001)(107046002)(64126003)(99136001)(105606002)(54356999)(19580405001)(76176999)(36756003)(6806004)(80316001)(83506001)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR0301MB0630;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0630; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601003);SRVR:BY2PR0301MB0630; X-Forefront-PRVS: 0422860ED4 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BY2PR0301MB0630; X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, On 12/10/2014 08:21 PM, Thierry Reding wrote: > On Wed, Dec 10, 2014 at 04:37:17PM +0800, Liu Ying wrote: >> The MIPI DSI bus driver would try to add a DSI device for a host's every >> child node which contains the reg property. Unfortunately, the existing >> i.MX6Q/SDL MIPI DSI host device tree node's child nodes contain the reg > > There aren't any existing nodes for the DSI host on i.MX. This patch > series adds support for them. There are existing nodes for the DSI host node. Please find them in arch/arm/boot/dts/imx6qdl.dtsi and arch/arm/boot/dts/imx6q.dts. The DSI host node contains two child nodes for i.MX6DL and another two for i.MX6Q. Each child node has a reg property embedded. > >> property, but the child nodes are ports pointing to dedicated CRTCs. >> So, this patch phases out the child nodes with input-port property before >> adding DSI devices for them and updates the MIPI DSI bus OF binding >> documentation. >> >> Signed-off-by: Liu Ying >> --- >> Documentation/devicetree/bindings/mipi/dsi/mipi-dsi-bus.txt | 4 ++++ >> drivers/gpu/drm/drm_mipi_dsi.c | 5 +++-- >> 2 files changed, 7 insertions(+), 2 deletions(-) > > Sorry, but NAK. There's no need for this special-case. I'll go into more > detail in response to patch 09/15. Thanks for reviewing the patches. Any idea how to handle the special case? The existing child nodes for the DSI host node do have the reg properties embedded. Regards, Liu Ying > > Thierry >