From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzAc-0007wl-EX for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:32:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyzAV-0005Z0-QA for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:32:22 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:35381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzAS-0005AB-7A for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:32:15 -0500 Message-ID: <548955F5.1080901@huawei.com> Date: Thu, 11 Dec 2014 16:29:41 +0800 From: Gonglei MIME-Version: 1.0 References: <1417691986-948-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1417691986-948-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] bootdevice: Refactor and improvement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gonglei (Arei)" Cc: "pbonzini@redhat.com" , "mst@redhat.com" , "Huangweidong (C)" , "qemu-devel@nongnu.org" , "Huangpeng (Peter)" On 2014/12/4 19:19, Gonglei (Arei) wrote: > From: Gonglei > > Patch 1 just move boot order related code to bootdevice.c. > Patch 2,3,5 add an argument to corresponding functions. > This way, we can propagate the error messages to the caller. > Maybe somebody will say we will remove the legacy boot order > in the future, instead of using bootindex. But at present, > for PPC, the have no way support bootindex, ARM on the flight > (Laszlo Ersek) as far as know. > > After this work, we can easily to add QMP command for existing > HMP command 'boot_set' if we have a requirement. > > Gonglei (5): > bootdevice: move code about bootorder from vl.c to bootdevice.c > bootdevice: add Error **errp argument for validate_bootdevices() > bootdevice: add Error **errp argument for qemu_boot_set() > bootdevice: add validate check for qemu_boot_set() > bootdevice: add Error **errp argument for QEMUBootSetHandler > > bootdevice.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++ > hw/i386/pc.c | 21 ++++++-------- > hw/ppc/mac_newworld.c | 4 +-- > hw/ppc/mac_oldworld.c | 5 ++-- > hw/sparc/sun4m.c | 4 +-- > hw/sparc64/sun4u.c | 4 +-- > include/hw/hw.h | 6 ---- > include/sysemu/sysemu.h | 7 +++++ > monitor.c | 14 ++++----- > vl.c | 77 +++++++++---------------------------------------- > 10 files changed, 116 insertions(+), 99 deletions(-) > Any comments and/or Acks will be appreciated. Then I'll send a pull request if no one is against this :) Regards, -Gonglei