From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XyzEF-0001MO-Cv for mharc-qemu-trivial@gnu.org; Thu, 11 Dec 2014 03:36:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzE8-0001M1-TN for qemu-trivial@nongnu.org; Thu, 11 Dec 2014 03:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyzE3-0006v5-Dc for qemu-trivial@nongnu.org; Thu, 11 Dec 2014 03:36:00 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:40234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzE2-0006uT-NA; Thu, 11 Dec 2014 03:35:55 -0500 Received: from 172.24.2.119 (EHLO szxeml450-hub.china.huawei.com) ([172.24.2.119]) by szxrg03-dlp.huawei.com (MOS 4.4.3-GA FastPath queued) with ESMTP id AYN56352; Thu, 11 Dec 2014 16:35:42 +0800 (CST) Received: from [127.0.0.1] (10.177.22.69) by szxeml450-hub.china.huawei.com (10.82.67.193) with Microsoft SMTP Server id 14.3.158.1; Thu, 11 Dec 2014 16:35:32 +0800 Message-ID: <54895753.20309@huawei.com> Date: Thu, 11 Dec 2014 16:35:31 +0800 From: zhanghailiang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Paolo Bonzini , References: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.22.69] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.54895765.008C, ss=1, re=0.001, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: fe2fe58975d0bbbe319bfdb9267cb43b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.66 Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com Subject: Re: [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 08:36:06 -0000 On 2014/12/10 17:17, Paolo Bonzini wrote: > superio_ioport_readb can read the 256th element of the array. > Coverity reports an out-of-bounds write in superio_ioport_writeb, > but it does not show the corresponding out-of-bounds read > because it cannot prove that it can happen. Fix the root > cause of the problem (zhanghailang's patch instead fixes > the logic in superio_ioport_writeb). > > Signed-off-by: Paolo Bonzini > --- > hw/isa/vt82c686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c > index e0c235c..a43e26d 100644 > --- a/hw/isa/vt82c686.c > +++ b/hw/isa/vt82c686.c > @@ -36,7 +36,7 @@ > > typedef struct SuperIOConfig > { > - uint8_t config[0xff]; > + uint8_t config[0x100]; > uint8_t index; > uint8_t data; > } SuperIOConfig; > Reviewed-by: zhanghailiang From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyzEI-0001Pz-TM for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:36:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyzEE-0006ws-2y for qemu-devel@nongnu.org; Thu, 11 Dec 2014 03:36:10 -0500 Message-ID: <54895753.20309@huawei.com> Date: Thu, 11 Dec 2014 16:35:31 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vt82c686: avoid out-of-bounds read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com On 2014/12/10 17:17, Paolo Bonzini wrote: > superio_ioport_readb can read the 256th element of the array. > Coverity reports an out-of-bounds write in superio_ioport_writeb, > but it does not show the corresponding out-of-bounds read > because it cannot prove that it can happen. Fix the root > cause of the problem (zhanghailang's patch instead fixes > the logic in superio_ioport_writeb). > > Signed-off-by: Paolo Bonzini > --- > hw/isa/vt82c686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c > index e0c235c..a43e26d 100644 > --- a/hw/isa/vt82c686.c > +++ b/hw/isa/vt82c686.c > @@ -36,7 +36,7 @@ > > typedef struct SuperIOConfig > { > - uint8_t config[0xff]; > + uint8_t config[0x100]; > uint8_t index; > uint8_t data; > } SuperIOConfig; > Reviewed-by: zhanghailiang