From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz447-0002ZI-Uu for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz441-00082U-Ce for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:45:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz440-00082C-So for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:45:53 -0500 Message-ID: <548996F9.9090600@redhat.com> Date: Thu, 11 Dec 2014 14:07:05 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418223122-22481-1-git-send-email-pbonzini@redhat.com> <1418223122-22481-2-git-send-email-pbonzini@redhat.com> <20141211124956.GA23351@noname.redhat.com> <5489937C.9040904@redhat.com> <20141211130237.GB23351@noname.redhat.com> In-Reply-To: <20141211130237.GB23351@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] linux-aio: queue requests that cannot be submitted List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: ming.lei@canonical.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com On 11/12/2014 14:02, Kevin Wolf wrote: >> > > > - } else { >> > > > - i = ret; >> > > > + abort(); >> > > > } > > > > > > abort() doesn't feel right here. > > > > man doesn't suggest any error that can actually happen. > > Yes. I guess I just like to be on the safe side. I would be fine with > dropping requests on the floor and thereby breaking the block device in > this unlikely case if proper error handling is too hard, but killing the > qemu process generally makes me feel uncomfortable. Hmm, since it shouldn't happen I prefer for it to fail right away and make it easier to spot what happened in the core dump. Paolo