From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45112)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xz440-0002VX-Uo
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:45:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xz43u-00081R-PW
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:45:52 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33258)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xz43t-00080p-PP
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:45:46 -0500
Message-ID: <54899FEE.6050103@redhat.com>
Date: Thu, 11 Dec 2014 14:45:18 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1418294973-21790-1-git-send-email-kraxel@redhat.com>
	<1418294973-21790-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1418294973-21790-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/10] sdl2: rename sdl2_state to
 sdl2_console, move to header file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>

On 2014-12-11 at 11:49, Gerd Hoffmann wrote:
> Create sdl2.h header file, in preparation for sdl2 code splitup.
> Populate it with sdl2_console struct (renamed from sdl2_state).
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   include/ui/sdl2.h | 11 ++++++++++
>   ui/sdl2.c         | 63 ++++++++++++++++++++++++-------------------------------
>   2 files changed, 38 insertions(+), 36 deletions(-)
>   create mode 100644 include/ui/sdl2.h
>
> diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
> new file mode 100644
> index 0000000..7f91a75
> --- /dev/null
> +++ b/include/ui/sdl2.h
> @@ -0,0 +1,11 @@
> +struct sdl2_console {
> +    DisplayChangeListener dcl;
> +    DisplaySurface *surface;
> +    SDL_Texture *texture;
> +    SDL_Window *real_window;
> +    SDL_Renderer *real_renderer;
> +    int idx;
> +    int last_vm_running; /* per console for caption reasons */
> +    int x, y;
> +    int hidden;
> +};

Is there a reason why you did not use include guards?

Max