All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Kirill Batuzov <batuzovk@ispras.ru>, Andrey Korolyov <andrey@xdel.ru>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] Serial: possible hang during intensive interaction over the console
Date: Thu, 11 Dec 2014 15:56:16 +0100	[thread overview]
Message-ID: <5489B090.4090500@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1409091702450.6072@bulbul.intra.ispras.ru>



On 09/09/2014 17:28, Kirill Batuzov wrote:
> In short: QEMU serial port transmits data as fast as it can ignoring
> baud rate completely. As a result we are stuck in serial8250_interrupt
> ISR in kernel most of the time.
> 
> Overall we have a large issue with rate control and flow control for
> virtual serial port implementations. In QEMU we have over dozen different
> UARTs for different platforms. Among them only one uses baud rate
> (strongarm) and only one implements flow control (16550A).
> 
> CC'ing some people to discuss general course of action in regards to
> serial implementation.
> 
> We probably want some abstract "serial" which is able to transmit one
> character with fixed baud rate and maximum retry count. The actual
> serial port implementations should implement interrupts, control
> registers and FIFO around it. With such design we will not need to
> implement the same bits of rate control and retry logic for every UART
> in QEMU.
> 
> Any thoughts on this?

The baud rate used to be there in the 8250 emulation.  It was removed
when flow control was added (why?), in commit fcfb4d6a.

Adding it back would be nice.

I think an abstraction of the "serial port" concept that is based on the
16550A register set, and with arbitrarily sized FIFOs, would be nice to
have.  All device models would talk to such abstraction.  The 16550A is
well known and a lot of devices take inspiration from it).

Paolo

  parent reply	other threads:[~2014-12-11 14:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-03 10:35 [Qemu-devel] Serial: possible hang during intensive interaction over the console Andrey Korolyov
2014-09-04  9:46 ` Kirill Batuzov
2014-09-04 10:00   ` Andrey Korolyov
2014-09-04 13:33     ` Kirill Batuzov
2014-09-04 16:03       ` Andrey Korolyov
2014-09-05 17:45         ` Andrey Korolyov
2014-09-09 15:28           ` Kirill Batuzov
2014-09-09 15:44             ` Andrey Korolyov
2014-12-11 14:56             ` Paolo Bonzini [this message]
2014-12-11 15:06               ` Peter Maydell
2014-12-11 19:35                 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5489B090.4090500@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=andrey@xdel.ru \
    --cc=armbru@redhat.com \
    --cc=batuzovk@ispras.ru \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.