All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: sonika.jindal@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Correcting the flushing of pipe
Date: Thu, 11 Dec 2014 15:20:39 +0000	[thread overview]
Message-ID: <5489B647.3090009@linux.intel.com> (raw)
In-Reply-To: <1418300895-17021-1-git-send-email-sonika.jindal@intel.com>


On 12/11/2014 12:28 PM, sonika.jindal@intel.com wrote:
> From: Sonika Jindal <sonika.jindal@intel.com>
>
> We were incorreectly bypassing the flush everytime which led to fifo
> underrun when more than one plane is enabled.
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_pm.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5748bf9..8cd045a 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3633,9 +3633,8 @@ static void skl_flush_wm_values(struct drm_i915_private *dev_priv,
>   		    skl_ddb_entry_size(&cur_ddb->pipe[pipe])) {
>   			skl_wm_flush_pipe(dev_priv, pipe, 2);
>   			intel_wait_for_vblank(dev, pipe);
> +			reallocated[pipe] = true;
>   		}
> -
> -		reallocated[pipe] = true;
>   	}
>
>   	/*

Works like a charm now!

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-12-11 15:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11 12:28 [PATCH] drm/i915/skl: Correcting the flushing of pipe sonika.jindal
2014-12-11 15:20 ` Tvrtko Ursulin [this message]
2014-12-15 10:12   ` Daniel Vetter
2014-12-11 19:39 ` shuang.he
2014-12-15 10:05 ` M, Satheeshakrishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5489B647.3090009@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=sonika.jindal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.