From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50843) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz5nt-000746-Li for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:37:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz5no-0007oU-KO for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:37:21 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:44333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz5no-0007oC-Df for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:37:16 -0500 Message-ID: <5489BA2A.9080306@imgtec.com> Date: Thu, 11 Dec 2014 15:37:14 +0000 From: Leon Alrae MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-mips: Use local float status pointer across MSA macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" , qemu-devel@nongnu.org Cc: Aurelien Jarno On 02/12/2014 17:51, Maciej W. Rozycki wrote: > Reduce line wrapping throughout MSA helper macros by using a local float > status pointer rather than referring to the float status through the > environment each time. No functional change. > > Signed-off-by: Maciej W. Rozycki > --- > Hi, > > The same float status applies across a single MSA operation (i.e. there > can't be an MT thread context switch in the middle) so there is no need > to get through the environment on each individual sub-operation. And at > any reasonable optimisation level code generated should be the same if > not better. The local pointer will help with a follow-up change that > would otherwise make line wrapping unbearable. > > Please apply, > > Maciej > > qemu-mips-msa-helper-status.diff > Index: qemu-git-trunk/target-mips/msa_helper.c Reviewed-by: Leon Alrae