From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: David Miller <davem@davemloft.net>, linux@arm.linux.org.uk
Cc: netdev@vger.kernel.org
Subject: Re: Bug: mv643xxx fails with highmem
Date: Thu, 11 Dec 2014 17:12:03 -0300 [thread overview]
Message-ID: <5489FA93.1030104@free-electrons.com> (raw)
In-Reply-To: <20141211.151055.817876561546126576.davem@davemloft.net>
On 12/11/2014 05:10 PM, David Miller wrote:
> From: Russell King - ARM Linux <linux@arm.linux.org.uk>
> Date: Thu, 11 Dec 2014 19:49:20 +0000
>
>> Commit 69ad0dd7af22 removed skb_frag_dma_map() in favour of mapping
>> all fragments with dma_map_single(). This fails when the driver is
>> used in an environment with highmem.
>
> This change looks really buggy to me.
>
> Unfortunately, all the changes he subsequently makes for software TSO
> support depend upon this :-/
>
> The change is definitely wrong.
>
Got it. I'll take a closer look and will try to think a fix for this.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-12-11 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 19:49 Bug: mv643xxx fails with highmem Russell King - ARM Linux
2014-12-11 20:10 ` David Miller
2014-12-11 20:12 ` Ezequiel Garcia [this message]
2014-12-11 20:25 ` Russell King - ARM Linux
2014-12-11 20:25 ` Ezequiel Garcia
2014-12-11 20:27 ` David Miller
2014-12-12 5:34 ` fugang.duan
2014-12-15 18:04 ` Russell King - ARM Linux
2014-12-16 2:19 ` fugang.duan
2014-12-16 10:57 ` Russell King - ARM Linux
2014-12-18 2:29 ` fugang.duan
2014-12-17 21:18 ` Ezequiel Garcia
2014-12-18 0:03 ` Russell King - ARM Linux
2014-12-18 13:13 ` Ezequiel Garcia
2014-12-21 16:51 ` Russell King - ARM Linux
2015-01-20 13:41 ` Russell King - ARM Linux
2015-01-20 13:42 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5489FA93.1030104@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=davem@davemloft.net \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.