From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Salter <msalter@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH] net: phy: export fixed_phy_register()
Date: Fri, 12 Dec 2014 04:31:48 -0800 [thread overview]
Message-ID: <548AE034.7070700@gmail.com> (raw)
In-Reply-To: <1418357006-2450-1-git-send-email-msalter@redhat.com>
Le 11/12/2014 20:03, Mark Salter a écrit :
> When building the bcmgenet driver as module, I get:
>
> ERROR: "fixed_phy_register" [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>
> commit b0ba512e225d72 ("net: bcmgenet: enable driver to work without device
> tree") which added a call to fixed_phy_register. But fixed_phy_register
> needs to be exported if used from a module.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
I will have to rework the GENET/SYSTEMPORT/SF2 dependencies anyway, thanks!
> ---
> drivers/net/phy/fixed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/phy/fixed.c b/drivers/net/phy/fixed.c
> index 47872caa..3ad0e6e 100644
> --- a/drivers/net/phy/fixed.c
> +++ b/drivers/net/phy/fixed.c
> @@ -274,6 +274,7 @@ struct phy_device *fixed_phy_register(unsigned int irq,
>
> return phy;
> }
> +EXPORT_SYMBOL_GPL(fixed_phy_register);
>
> static int __init fixed_mdio_bus_init(void)
> {
>
next prev parent reply other threads:[~2014-12-12 4:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 4:03 [PATCH] net: phy: export fixed_phy_register() Mark Salter
2014-12-12 12:31 ` Florian Fainelli [this message]
2014-12-12 16:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AE034.7070700@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.