From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzRD4-0008Sk-R9 for qemu-devel@nongnu.org; Fri, 12 Dec 2014 09:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzRCz-0004OH-KL for qemu-devel@nongnu.org; Fri, 12 Dec 2014 09:28:46 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:36990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzRCz-0004Nm-DW for qemu-devel@nongnu.org; Fri, 12 Dec 2014 09:28:41 -0500 Message-ID: <548AFB94.3070800@imgtec.com> Date: Fri, 12 Dec 2014 14:28:36 +0000 From: Leon Alrae MIME-Version: 1.0 References: <1418376603-18360-1-git-send-email-leon.alrae@imgtec.com> <1418376603-18360-4-git-send-email-leon.alrae@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] disas/mips: remove unused mips16_to_32_reg_map[] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Aurelien Jarno On 12/12/2014 12:25, Peter Maydell wrote: > On 12 December 2014 at 09:30, Leon Alrae wrote: >> The array was "used" in a block of code which has never been enabled. Therefore >> removing the array as well as 700 lines of never used code. > > That's quite a lot to remove -- are you sure we're never going to want > to disassemble mips16 insns in future? I quickly tried to enable it but it doesn't seem to be complete. For example it requires "extern const struct mips_opcode mips16_opcodes[]" which isn't anywhere in the codebase. Moreover, according to the git blame it has always been disabled since 2005 thus in my opinion there is no point in keeping this code. I do want to disassemble mips16 insns, if someone has proper implementation I'm more than happy to include it. Regards, Leon