From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add an intermediate software queue implementation
Date: Fri, 12 Dec 2014 15:28:44 +0100 [thread overview]
Message-ID: <548AFB9C.1060408@openwrt.org> (raw)
In-Reply-To: <1418392866.2470.49.camel@sipsolutions.net>
On 2014-12-12 15:01, Johannes Berg wrote:
> On Fri, 2014-12-12 at 14:40 +0100, Felix Fietkau wrote:
>
>> > Then
>> > again what even sets vif->txq? Shouldn't those be per-AC? Do you really
>> > want to mix 'normal' and txq-TX?
>> Are we even using multiple ACs for packets that don't belong to a
>> particular sta? I thought normal mcast data frames only use non-QoS
>> frames. And yes, I'm currently mixing normal and txq-TX to prioritize
>> ctl/mgmt frames over other less important traffic.
>
> Management (and maybe control) frames can have different priorities as
> well, this is only used for something with TDLS now I think though.
With my implementation, those would go through the normal tx codepath,
bypassing the software tx queues. Can you think of anything else that
would need per-AC vif queues?
- Felix
next prev parent reply other threads:[~2014-12-12 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 23:14 [PATCH] mac80211: add an intermediate software queue implementation Felix Fietkau
2014-12-12 13:21 ` Johannes Berg
2014-12-12 13:40 ` Felix Fietkau
2014-12-12 14:01 ` Johannes Berg
2014-12-12 14:28 ` Felix Fietkau [this message]
2014-12-15 12:00 ` Johannes Berg
2014-12-15 23:25 ` Bartosz Szczepanek
2014-12-16 9:08 ` Felix Fietkau
2014-12-31 14:28 ` Johan Almbladh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AFB9C.1060408@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.