From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [PATCH 1/1] reiserfs: destroy allocated commit workqueue Date: Fri, 12 Dec 2014 17:02:07 +0100 Message-ID: <548B117F.7090509@suse.cz> References: <1418398169-19820-1-git-send-email-jslaby@suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=v506WAYP2Tvtp3v8d9DeeeCngwYvl2CbgrgWBvQHtQg=; b=KgQGNfdhUXzr3NEySOP0R0yMFvH3rz9yaVgOXvG99JqiOdukoYgKT8BlIjeVBl3p3L tcM45sMVGmJwBaOhntT8ZJfOHscQacCf0nDfz0b3YVH5SfmXUcH0L+DVrrysf4V96y9S b/YpS5gt1ZFaQ6LI8wM41U3F02FBhfUDCD11P9ZhFY7v7TU2zTZm7u82ZLiSI4nZK93d IQMLI/YyoMicImWoQsQq7D7Zj3QeTVT6lQcsNMMm3aiq5y5/57aLYJYMPO03JcnkdBpH +qUqb93HULVF7HSV5asrdkwH77FUMW4QtToOncBvsfFD8JbHhJ6kfYyiBfsMewitd+7v bnjA== In-Reply-To: <1418398169-19820-1-git-send-email-jslaby@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="macroman" To: reiserfs-devel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jan Kara , All Versions , Jeff Mahoney On 12/12/2014, 04:29 PM, Jiri Slaby wrote: > When resirefs is trying to mount a partition, it creates a commit > workqueue (sbi->commit_wq). But when mount fails later, the workqueue > is not freed. >=20 > Signed-off-by: Jiri Slaby > Reported-by: auxsvr@gmail.com > Reported-by: Beno=C3=AEt Monin > Cc: Jan Kara > Cc: All Versions This is not quite correct. It was introduced in commit 797d9016ceca69879bb273218810fa0beef46aac (reiserfs: use per-fs commit workqueues), so only 3.16+ is affected. > Cc: reiserfs-devel@vger.kernel.org > --- > fs/reiserfs/super.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c > index ea63ab13ef92..71fbbe3e2dab 100644 > --- a/fs/reiserfs/super.c > +++ b/fs/reiserfs/super.c > @@ -2172,6 +2172,9 @@ error_unlocked: > reiserfs_write_unlock(s); > } > =20 > + if (sbi->commit_wq) > + destroy_workqueue(sbi->commit_wq); > + > cancel_delayed_work_sync(&REISERFS_SB(s)->old_work); > =20 > reiserfs_free_bitmap_cache(s); >=20 --=20 js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030657AbaLLQCQ (ORCPT ); Fri, 12 Dec 2014 11:02:16 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:40006 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030544AbaLLQCL (ORCPT ); Fri, 12 Dec 2014 11:02:11 -0500 Message-ID: <548B117F.7090509@suse.cz> Date: Fri, 12 Dec 2014 17:02:07 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: reiserfs-devel@vger.kernel.org CC: linux-kernel@vger.kernel.org, Jan Kara , All Versions , Jeff Mahoney Subject: Re: [PATCH 1/1] reiserfs: destroy allocated commit workqueue References: <1418398169-19820-1-git-send-email-jslaby@suse.cz> In-Reply-To: <1418398169-19820-1-git-send-email-jslaby@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2014, 04:29 PM, Jiri Slaby wrote: > When resirefs is trying to mount a partition, it creates a commit > workqueue (sbi->commit_wq). But when mount fails later, the workqueue > is not freed. > > Signed-off-by: Jiri Slaby > Reported-by: auxsvr@gmail.com > Reported-by: Benoît Monin > Cc: Jan Kara > Cc: All Versions This is not quite correct. It was introduced in commit 797d9016ceca69879bb273218810fa0beef46aac (reiserfs: use per-fs commit workqueues), so only 3.16+ is affected. > Cc: reiserfs-devel@vger.kernel.org > --- > fs/reiserfs/super.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c > index ea63ab13ef92..71fbbe3e2dab 100644 > --- a/fs/reiserfs/super.c > +++ b/fs/reiserfs/super.c > @@ -2172,6 +2172,9 @@ error_unlocked: > reiserfs_write_unlock(s); > } > > + if (sbi->commit_wq) > + destroy_workqueue(sbi->commit_wq); > + > cancel_delayed_work_sync(&REISERFS_SB(s)->old_work); > > reiserfs_free_bitmap_cache(s); > -- js suse labs