Re: [PATCH for-4.6 4/4] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt

[Julien Grall <julien.grall@linaro.org>]

On 12/12/14 14:43, Julien Grall wrote:
> diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
> index 7221bc8..7d14377 100644
> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -543,10 +543,17 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags)
>      if ( (rc = domain_vtimer_init(d)) != 0 )
>          goto fail;
>  
> -    if ( d->domain_id )
> +    /*
> +     * The hardware domain will get a PPI later in
> +     * arch/arm/domain_build.c  depending on the
> +     * interrupt map of the hardware.
> +     */
> +    if ( !is_hardware_domain(d) )
> +    {
>          d->arch.evtchn_irq = GUEST_EVTCHN_PPI;
> -    else
> -        d->arch.evtchn_irq = platform_dom0_evtchn_ppi();
> +        /* At this stage vgic_reserve_virq should never fail */
> +        BUG_ON(vgic_reserve_virq(d, GUEST_EVTCHN_PPI));

I forgot the "!" in the BUG_ON. This line should be:

BUG_ON(!..)


-- 
Julien Grall