From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XzVvn-0000RA-Ra
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 14:31:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XzVve-0002rD-G1
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 14:31:15 -0500
Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:44512)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XzVve-0002r7-AH
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 14:31:06 -0500
Received: by mail-qc0-f171.google.com with SMTP id r5so6040654qcx.16
	for <qemu-devel@nongnu.org>; Fri, 12 Dec 2014 11:31:05 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <548B4275.70901@twiddle.net>
Date: Fri, 12 Dec 2014 11:31:01 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1418405504-11175-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1418405504-11175-2-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1418405504-11175-2-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] target-tricore: Change SSOV/SUOV makro
	name to SSOV32/SUOV32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org

On 12/12/2014 09:31 AM, Bastian Koppelmann wrote:
> -#define SSOV(env, ret, arg, len) do {               \
> -    int64_t max_pos = INT##len ##_MAX;              \
> -    int64_t max_neg = INT##len ##_MIN;              \
> +#define SSOV32(env, ret, arg) do {                  \
> +    int64_t max_pos = INT32_MAX;                    \
> +    int64_t max_neg = INT32_MIN;                    \

Now that you don't need token pasting, I think these would
be better as regular functions than macros.


r~