From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:47587 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964951AbaLMDwP (ORCPT ); Fri, 12 Dec 2014 22:52:15 -0500 Message-ID: <548BB7EA.1050502@iki.fi> Date: Sat, 13 Dec 2014 05:52:10 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Benjamin Larsson CC: Linux Media Mailing List Subject: Re: [PATCH 1/4] mn88472: implement dvb-t signal lock References: <1418429925-16342-1-git-send-email-benjamin@southpole.se> In-Reply-To: <1418429925-16342-1-git-send-email-benjamin@southpole.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: That breaks DVB-C lock check as old "utmp = 0x08" was set according to DVB-C lock check, right? Antti On 12/13/2014 02:18 AM, Benjamin Larsson wrote: > Signed-off-by: Benjamin Larsson > --- > drivers/staging/media/mn88472/mn88472.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c > index 107552a..4d80046 100644 > --- a/drivers/staging/media/mn88472/mn88472.c > +++ b/drivers/staging/media/mn88472/mn88472.c > @@ -238,6 +238,7 @@ static int mn88472_read_status(struct dvb_frontend *fe, fe_status_t *status) > struct dtv_frontend_properties *c = &fe->dtv_property_cache; > int ret; > unsigned int utmp; > + int lock = 0; > > *status = 0; > > @@ -248,6 +249,12 @@ static int mn88472_read_status(struct dvb_frontend *fe, fe_status_t *status) > > switch (c->delivery_system) { > case SYS_DVBT: > + ret = regmap_read(dev->regmap[0], 0x7F, &utmp); > + if (ret) > + goto err; > + if ((utmp&0xF) > 8) > + lock = 1; > + break; > case SYS_DVBT2: > /* FIXME: implement me */ > utmp = 0x08; /* DVB-C lock value */ > @@ -262,7 +269,7 @@ static int mn88472_read_status(struct dvb_frontend *fe, fe_status_t *status) > goto err; > } > > - if (utmp == 0x08) > + if (lock) > *status = FE_HAS_SIGNAL | FE_HAS_CARRIER | FE_HAS_VITERBI | > FE_HAS_SYNC | FE_HAS_LOCK; > > -- http://palosaari.fi/