All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Vinson Lee <vlee@twopensource.com>, stable@vger.kernel.org
Cc: Nadav Har'El <nyh@il.ibm.com>,
	Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
	Jun Nakajima <jun.nakajima@intel.com>,
	Xinhao Xu <xinhao.xu@intel.com>,
	Yang Zhang <yang.z.zhang@Intel.com>,
	Gleb Natapov <gleb@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [stable request 3.4 3.10] nEPT: Nested INVEPT
Date: Sat, 13 Dec 2014 10:09:06 +0100	[thread overview]
Message-ID: <548C0232.7030007@redhat.com> (raw)
In-Reply-To: <CAHTgTXW1Un18BGz75SZeeH5gutd5JjJPkPJgMiatSKC9-1_0OQ@mail.gmail.com>



On 13/12/2014 02:13, Vinson Lee wrote:
> Please consider upstream 3.12 commit
> bfd0a56b90005f8c8a004baf407ad90045c2b11e "nEPT: Nested INVEPT" for
> stable trees 3.4 and 3.10. This patch addresses CVE-2014-3645. It has
> already been backported to 3.2 in 3.2.64.

Note that the patch for 3.4 and 3.10 can be much simpler:

https://lkml.org/lkml/2014/11/2/48

Paolo

> commit bfd0a56b90005f8c8a004baf407ad90045c2b11e
> Author: Nadav Har'El <nyh@il.ibm.com>
> Date:   Mon Aug 5 11:07:17 2013 +0300
> 
>     nEPT: Nested INVEPT
> 
>     If we let L1 use EPT, we should probably also support the INVEPT
> instruction.
> 
>     In our current nested EPT implementation, when L1 changes its EPT table
>     for L2 (i.e., EPT12), L0 modifies the shadow EPT table (EPT02), and in
>     the course of this modification already calls INVEPT. But if last level
>     of shadow page is unsync not all L1's changes to EPT12 are intercepted,
>     which means roots need to be synced when L1 calls INVEPT. Global INVEPT
>     should not be different since roots are synced by kvm_mmu_load() each
>     time EPTP02 changes.
> 
>     Reviewed-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
>     Signed-off-by: Nadav Har'El <nyh@il.ibm.com>
>     Signed-off-by: Jun Nakajima <jun.nakajima@intel.com>
>     Signed-off-by: Xinhao Xu <xinhao.xu@intel.com>
>     Signed-off-by: Yang Zhang <yang.z.zhang@Intel.com>
>     Signed-off-by: Gleb Natapov <gleb@redhat.com>
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> 
> Cheers,
> Vinson
> 

  reply	other threads:[~2014-12-13  9:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-13  1:13 [stable request 3.4 3.10] nEPT: Nested INVEPT Vinson Lee
2014-12-13  9:09 ` Paolo Bonzini [this message]
2014-12-24  7:58   ` Zefan Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548C0232.7030007@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gleb@redhat.com \
    --cc=jun.nakajima@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=nyh@il.ibm.com \
    --cc=stable@vger.kernel.org \
    --cc=vlee@twopensource.com \
    --cc=xiaoguangrong@linux.vnet.ibm.com \
    --cc=xinhao.xu@intel.com \
    --cc=yang.z.zhang@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.