From: Steve Dickson <SteveD@redhat.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
libtirpc-devel@lists.sourceforge.net
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH libtirpc v2] pkg-config: needs pthread as private library
Date: Sat, 13 Dec 2014 09:40:07 -0500 [thread overview]
Message-ID: <548C4FC7.6010001@RedHat.com> (raw)
In-Reply-To: <1416764609-1822-1-git-send-email-yann.morin.1998@free.fr>
On 11/23/2014 12:43 PM, Yann E. MORIN wrote:
> libtirpc needs pthreads. This is automatically pulled in when linking
> with the shared library, thanks to the DT_NEEDED ELF tags.
>
> But for a static library, there is no such mechanism to identify
> required libraries.
>
> Thus, add -lpthread to the private libraries in the pkg-config file.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Steve Dickson <steved@redhat.com>
Committed...
steved.
>
> ---
> Changes v1 -> v2:
> - posted publicly in appropriate locations (thanks Steve)
> ---
> libtirpc.pc.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libtirpc.pc.in b/libtirpc.pc.in
> index ec4cf75..38034c5 100644
> --- a/libtirpc.pc.in
> +++ b/libtirpc.pc.in
> @@ -8,4 +8,5 @@ Description: Transport Independent RPC Library
> Requires:
> Version: @PACKAGE_VERSION@
> Libs: -L@libdir@ -ltirpc
> +Libs.private: -lpthread
> Cflags: -I@includedir@/tirpc
>
prev parent reply other threads:[~2014-12-13 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 17:43 [PATCH libtirpc v2] pkg-config: needs pthread as private library Yann E. MORIN
2014-11-29 18:15 ` Yann E. MORIN
2014-12-13 14:40 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548C4FC7.6010001@RedHat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.