From: Benjamin Larsson <benjamin@southpole.se>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators
Date: Sat, 13 Dec 2014 19:52:31 +0100 [thread overview]
Message-ID: <548C8AEF.1090907@southpole.se> (raw)
In-Reply-To: <548C4096.5030401@iki.fi>
On 12/13/2014 02:35 PM, Antti Palosaari wrote:
>
>
> Do you understand that code at all?
No I can't really say I understand all the workings of the media api.
>
> Now it is:
> FE0 == (fe->id == 0) == RTL2832
> FE1 == (fe->id == 1) == MN88472
>
> you changed it to:
> FE0 == (fe->id == 0) == MN88472
> FE1 == (fe->id == 1) == RTL2832
I thought the rtl2832u_frontend_attach() actually attached the devices.
Then the id's would have followed the frontend.
>
> Then there is:
>
> /* bypass slave demod TS through master demod */
> if (fe->id == 1 && onoff) {
> ret = rtl2832_enable_external_ts_if(adap->fe[1]);
> if (ret)
> goto err;
> }
>
> After your change that code branch is taken when RTL2832 demod is
> activated / used. Shouldn't TS bypass enabled just opposite, when
> MN88472 is used....
>
>
> Antti
>
This intent of the patch was for better backwards compatibility with old
software. This isn't strictly needed so consider the patch dropped.
MvH
Benjamin Larsson
next prev parent reply other threads:[~2014-12-13 18:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 0:18 [PATCH 1/4] mn88472: implement dvb-t signal lock Benjamin Larsson
2014-12-13 0:18 ` [PATCH 2/4] rtl28xxu: swap frontend order for devices with slave demodulators Benjamin Larsson
2014-12-13 4:02 ` Antti Palosaari
2014-12-13 11:09 ` Benjamin Larsson
2014-12-13 13:35 ` Antti Palosaari
2014-12-13 18:52 ` Benjamin Larsson [this message]
2014-12-14 8:05 ` Antti Palosaari
2014-12-14 19:17 ` Benjamin Larsson
2014-12-13 0:18 ` [PATCH 3/4] mn88472: elaborate debug printout Benjamin Larsson
2014-12-13 4:05 ` Antti Palosaari
2014-12-13 0:18 ` [PATCH 4/4] mn88472: implemented ber reporting Benjamin Larsson
2014-12-13 4:15 ` Antti Palosaari
2014-12-13 11:12 ` Benjamin Larsson
2014-12-14 8:35 ` Antti Palosaari
2014-12-13 3:52 ` [PATCH 1/4] mn88472: implement dvb-t signal lock Antti Palosaari
2014-12-13 11:13 ` Benjamin Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548C8AEF.1090907@southpole.se \
--to=benjamin@southpole.se \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.