From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:37532 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbaLNL3G (ORCPT ); Sun, 14 Dec 2014 06:29:06 -0500 Message-ID: <548D747E.6060404@iki.fi> Date: Sun, 14 Dec 2014 13:29:02 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Jurgen Kramer , linux-media@vger.kernel.org CC: Olli Salonen Subject: Re: [PATCH] Si2168: increase timeout to fix firmware loading References: <1418027444-4718-1-git-send-email-gtmkramer@xs4all.nl> <5485E572.9010801@iki.fi> In-Reply-To: <5485E572.9010801@iki.fi> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 12/08/2014 07:52 PM, Antti Palosaari wrote: > On 12/08/2014 10:30 AM, Jurgen Kramer wrote: >> Increase si2168 cmd execute timeout to prevent firmware load failures. >> Tests >> shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' >> firmware. >> Increase timeout to a safe value of 70ms. >> >> Signed-off-by: Jurgen Kramer > Reviewed-by: Antti Palosaari > Cc: # v3.17+ Cc: # v3.16+ Changed from stable 3.17+ to 3.16+ as I found that PCTV 292e timeouts too when tuning DVB-T2, not always, but from time to time... Antti > > That must go stable 3.17. > > Antti > >> --- >> drivers/media/dvb-frontends/si2168.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/dvb-frontends/si2168.c >> b/drivers/media/dvb-frontends/si2168.c >> index ce9ab44..d2f1a3e 100644 >> --- a/drivers/media/dvb-frontends/si2168.c >> +++ b/drivers/media/dvb-frontends/si2168.c >> @@ -39,7 +39,7 @@ static int si2168_cmd_execute(struct si2168 *s, >> struct si2168_cmd *cmd) >> >> if (cmd->rlen) { >> /* wait cmd execution terminate */ >> - #define TIMEOUT 50 >> + #define TIMEOUT 70 >> timeout = jiffies + msecs_to_jiffies(TIMEOUT); >> while (!time_after(jiffies, timeout)) { >> ret = i2c_master_recv(s->client, cmd->args, cmd->rlen); >> > -- http://palosaari.fi/