From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41375)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1Y0R6a-0000Q4-47
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:34:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1Y0R6V-0003Ay-F1
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:34:12 -0500
Received: from relay.parallels.com ([195.214.232.42]:44208)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1Y0R6V-0002zS-8J
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:34:07 -0500
Message-ID: <548E9CBD.5080104@parallels.com>
Date: Mon, 15 Dec 2014 11:33:01 +0300
From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
MIME-Version: 1.0
References: <1418307457-25996-1-git-send-email-vsementsov@parallels.com>
	<1418307457-25996-9-git-send-email-vsementsov@parallels.com>
	<5489B5C8.5090500@redhat.com>
In-Reply-To: <5489B5C8.5090500@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, stefanha@redhat.com

Thanks. It's interesting that checkpatch.pl doesn't warn about this line.

Best regards,
Vladimir

On 11.12.2014 18:18, Eric Blake wrote:
> On 12/11/2014 07:17 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Add dirty parameter to qmp-migrate command. If this parameter is true,
>> block-migration.c will migrate dirty bitmaps. This parameter can be used
>> without "blk" parameter to migrate only dirty bitmaps, skipping block
>> migration.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
>> ---
>> +++ b/qapi-schema.json
>> @@ -1660,7 +1660,7 @@
>>   # Since: 0.14.0
>>   ##
>>   { 'command': 'migrate',
>> -  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' } }
>> +  'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*dirty': 'bool', '*detach': 'bool' } }
> Missing documentation of the new option (including a mention of '(since
> 2.3)'.  Also, please keep lines shorter than 80 columns.
>