From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuankuan.Yang" Subject: Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio Date: Mon, 15 Dec 2014 21:10:26 +0800 Message-ID: <548EDDC2.9050104@rock-chips.com> References: <1418609494-15820-1-git-send-email-ykk@rock-chips.com> <1418612114-19692-1-git-send-email-ykk@rock-chips.com> <20141215104029.GE11285@n2100.arm.linux.org.uk> <20141215120205.GZ11764@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141215120205.GZ11764-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown , Russell King - ARM Linux Cc: Heiko Stuebner , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org, Fabio Estevam , Shawn Guo , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Kurtz , Sonny Rao , Dylan Reid , Xu Jianqun , =?UTF-8?B?U3Tvv73vv71waGFuZSBNYXJjaGVzaW4=?= , Lars-Peter Clausen , Brian Austin , Bard Liao , Max Filippov , Oder Chiou , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel@lists. List-Id: alsa-devel@alsa-project.org Hi Mark & Russell: thanks for your replay, what your say is right, those dt is merely=20 describing the Linux kernel internals. Instead of transmit cpu-of-node & codec-name & codec-dai-name through=20 dt, i can give those an const name to rockchip-hdmi-audio.c . In that way, dt will only need compatible for creating sound device. is= =20 it ok ? sound { compatible =3D "rockchip,rk3288-hdmi-audio"; status =3D "okay"; } could you give me some advises. Best Regards. =E5=9C=A8 2014=E5=B9=B412=E6=9C=8815=E6=97=A5 20:02, Mark Brown =E5=86=99= =E9=81=93: > On Mon, Dec 15, 2014 at 10:40:29AM +0000, Russell King - ARM Linux wr= ote: > >> Including details like this (because ASoC needs a separate DT node) = is >> the wrong approach. > And indeed there should be no Linux-internal reason for that - we sho= uld > be able to use whatever DT node makes sense, if there's some reason > that's not possible we should fix that (we do have several drivers do= ing > this sort of thing already though). -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Kuankuan.Yang) Date: Mon, 15 Dec 2014 21:10:26 +0800 Subject: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio In-Reply-To: <20141215120205.GZ11764@sirena.org.uk> References: <1418609494-15820-1-git-send-email-ykk@rock-chips.com> <1418612114-19692-1-git-send-email-ykk@rock-chips.com> <20141215104029.GE11285@n2100.arm.linux.org.uk> <20141215120205.GZ11764@sirena.org.uk> Message-ID: <548EDDC2.9050104@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark & Russell: thanks for your replay, what your say is right, those dt is merely describing the Linux kernel internals. Instead of transmit cpu-of-node & codec-name & codec-dai-name through dt, i can give those an const name to rockchip-hdmi-audio.c . In that way, dt will only need compatible for creating sound device. is it ok ? sound { compatible = "rockchip,rk3288-hdmi-audio"; status = "okay"; } could you give me some advises. Best Regards. ? 2014?12?15? 20:02, Mark Brown ??: > On Mon, Dec 15, 2014 at 10:40:29AM +0000, Russell King - ARM Linux wrote: > >> Including details like this (because ASoC needs a separate DT node) is >> the wrong approach. > And indeed there should be no Linux-internal reason for that - we should > be able to use whatever DT node makes sense, if there's some reason > that's not possible we should fix that (we do have several drivers doing > this sort of thing already though). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272AbaLONKy (ORCPT ); Mon, 15 Dec 2014 08:10:54 -0500 Received: from regular1.263xmail.com ([211.150.99.138]:45163 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbaLONKw (ORCPT ); Mon, 15 Dec 2014 08:10:52 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: jsarha@ti.com X-SENDER-IP: 104.167.231.21 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <90ef963fec11cdd59836aa28bcaae6f1> X-DNS-TYPE: 0 Message-ID: <548EDDC2.9050104@rock-chips.com> Date: Mon, 15 Dec 2014 21:10:26 +0800 From: "Kuankuan.Yang" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Mark Brown , Russell King - ARM Linux CC: Heiko Stuebner , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Zubair.Kakakhel@imgtec.com, Fabio Estevam , Shawn Guo , dri-devel@lists.freedesktop.org, Daniel Kurtz , Sonny Rao , Dylan Reid , Xu Jianqun , =?UTF-8?B?U3Tvv73vv71waGFuZSBNYXJjaGVzaW4=?= , Lars-Peter Clausen , Brian Austin , Bard Liao , Max Filippov , Oder Chiou , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, Arnd Bergmann , David Airlie , Sean Cross , Grant Likely , Greg Kroah-Hartman , Ben Zhang , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Jyri Sarha Subject: Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio References: <1418609494-15820-1-git-send-email-ykk@rock-chips.com> <1418612114-19692-1-git-send-email-ykk@rock-chips.com> <20141215104029.GE11285@n2100.arm.linux.org.uk> <20141215120205.GZ11764@sirena.org.uk> In-Reply-To: <20141215120205.GZ11764@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark & Russell: thanks for your replay, what your say is right, those dt is merely describing the Linux kernel internals. Instead of transmit cpu-of-node & codec-name & codec-dai-name through dt, i can give those an const name to rockchip-hdmi-audio.c . In that way, dt will only need compatible for creating sound device. is it ok ? sound { compatible = "rockchip,rk3288-hdmi-audio"; status = "okay"; } could you give me some advises. Best Regards. 在 2014年12月15日 20:02, Mark Brown 写道: > On Mon, Dec 15, 2014 at 10:40:29AM +0000, Russell King - ARM Linux wrote: > >> Including details like this (because ASoC needs a separate DT node) is >> the wrong approach. > And indeed there should be no Linux-internal reason for that - we should > be able to use whatever DT node makes sense, if there's some reason > that's not possible we should fix that (we do have several drivers doing > this sort of thing already though).