All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Scott Duplichan <scott-CDj6QYrFEYEdnm+yROfE0A@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [cbootimage PATCH] cbootimage: Add 'b' (binary) flag when using fopen to open a binary file.
Date: Mon, 15 Dec 2014 10:27:55 -0700	[thread overview]
Message-ID: <548F1A1B.5020708@wwwdotorg.org> (raw)
In-Reply-To: <000f01d017bf$61e0cfe0$25a26fa0$@notabs.org>

On 12/14/2014 09:59 AM, Scott Duplichan wrote:
> Add 'b' (binary) flag when using fopen to open a binary file.
> This keeps Windows from expanding \n to \r\n and interpreting
> <ctrl>z as end of file. The change is to support a Windows
> hosted coreboot build environment.

This seems fine; I'll apply it in just a second.

It seems worth being explicit on all fopens re: b-vs-t. To that end, 
perhaps you could update the following too?

> ./src/cbootimage.c:161:	context->config_file = fopen(argv[optind++], "r");
> ./src/cbootimage.c:218:	context.raw_file = fopen(context.output_image_filename, "w+");
> ./src/data_layout.c:1049:	fp = fopen(context->input_image_filename, "r");

  reply	other threads:[~2014-12-15 17:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14 16:59 [cbootimage PATCH] cbootimage: Add 'b' (binary) flag when using fopen to open a binary file Scott Duplichan
2014-12-15 17:27 ` Stephen Warren [this message]
     [not found]   ` <548F1A1B.5020708-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-12-15 21:16     ` Scott Duplichan
2014-12-15 22:05       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548F1A1B.5020708@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=scott-CDj6QYrFEYEdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.