From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Y0dGq-0006d2-0G
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:33:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Y0dGk-0002Ll-9v
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:33:35 -0500
Received: from mail-qc0-f177.google.com ([209.85.216.177]:41237)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cminyard@mvista.com>) id 1Y0dGk-0002LP-64
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:33:30 -0500
Received: by mail-qc0-f177.google.com with SMTP id x3so9349640qcv.36
	for <qemu-devel@nongnu.org>; Mon, 15 Dec 2014 13:33:28 -0800 (PST)
Message-ID: <548F53A5.6000609@mvista.com>
Date: Mon, 15 Dec 2014 15:33:25 -0600
From: Corey Minyard <cminyard@mvista.com>
MIME-Version: 1.0
References: <1418411751-3614-1-git-send-email-minyard@acm.org>
	<1418411751-3614-17-git-send-email-minyard@acm.org>
	<548F4E81.2010205@redhat.com>
In-Reply-To: <548F4E81.2010205@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better
	simulate a BMC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, minyard@acm.org, qemu-devel@nongnu.org

On 12/15/2014 03:11 PM, Paolo Bonzini wrote:
>
> On 12/12/2014 20:15, minyard@acm.org wrote:
>> +    if (s->threaded_bmc) {
>> +        qemu_mutex_init(&s->lock);
>> +        qemu_cond_init(&s->waker);
>> +        qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0);
>> +    }
>> +
>> +    if (s->threaded_bmc) {
>> +        qemu_mutex_init(&s->lock);
>> +        qemu_cond_init(&s->waker);
>> +        qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0);
>> +    }
>> +
> Duplicated bit---probably a rebase hiccup?

Almost certainly.  Got it, Thanks.

-corey