From: Saul Wold <sgw@linux.intel.com>
To: akuster808 <akuster808@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssh: move setting LD to allow for correct override
Date: Mon, 15 Dec 2014 13:59:31 -0800 [thread overview]
Message-ID: <548F59C3.6010500@linux.intel.com> (raw)
In-Reply-To: <548F4684.9000401@gmail.com>
On 12/15/2014 12:37 PM, akuster808 wrote:
> Saul,
>
> is this needed for dizzy too?
>
Yes and daisy, which I will do when this gets merged, I was going to
wait until it was in head before asking for the backport.
Sau!
> - Armin
>
> On 12/15/2014 11:21 AM, Saul Wold wrote:
>> Using the export LD in the recipe does not allow for secodnary toolchain
>> overriding LD later, by setting it in the do_configure_append the export
>> is used by autotools setting LD based on the env, but would allow for
>> override later.
>>
>> [YOCTO #6997]
>>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>> meta/recipes-connectivity/openssh/openssh_6.6p1.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/openssh/openssh_6.6p1.bb
>> b/meta/recipes-connectivity/openssh/openssh_6.6p1.bb
>> index dbcf414..abc302b 100644
>> --- a/meta/recipes-connectivity/openssh/openssh_6.6p1.bb
>> +++ b/meta/recipes-connectivity/openssh/openssh_6.6p1.bb
>> @@ -49,7 +49,6 @@ inherit autotools-brokensep ptest
>>
>> # LFS support:
>> CFLAGS += "-D__FILE_OFFSET_BITS=64"
>> -export LD = "${CC}"
>>
>> # login path is hardcoded in sshd
>> EXTRA_OECONF = "'LOGIN_PROGRAM=${base_bindir}/login' \
>> @@ -74,6 +73,7 @@ CACHED_CONFIGUREVARS +=
>> "ac_cv_path_PATH_PASSWD_PROG=${bindir}/passwd"
>> EXTRA_OECONF_append_libc-uclibc=" --without-pam"
>>
>> do_configure_prepend () {
>> + export LD="${CC}"
>> install -m 0644 ${WORKDIR}/sshd_config ${B}/
>> install -m 0644 ${WORKDIR}/ssh_config ${B}/
>> if [ ! -e acinclude.m4 -a -e aclocal.m4 ]; then
>>
>
>
prev parent reply other threads:[~2014-12-15 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 19:21 [PATCH] openssh: move setting LD to allow for correct override Saul Wold
2014-12-15 20:37 ` akuster808
2014-12-15 21:59 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F59C3.6010500@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=akuster808@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.