From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0gW8-0001lS-F5 for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:01:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0gW3-0003F6-DM for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:01:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36879 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0gW3-0003F0-7G for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:01:31 -0500 Message-ID: <548F8469.7020402@suse.de> Date: Tue, 16 Dec 2014 02:01:29 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1418690628-20652-1-git-send-email-david@gibson.dropbear.id.au> <1418690628-20652-3-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1418690628-20652-3-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/5] pseries: Add spapr_rtc_read() helper function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , aik@ozlabs.ru, mdroth@us.ibm.com Cc: paulus@samba.org, qemu-devel@nongnu.org On 16.12.14 01:43, David Gibson wrote: > The virtual RTC time is used in two places in the pseries machine. First > is in the RTAS get-time-of-day function which returns the RTC time to the > guest. Second is in the spapr events code which is used to timestamp > event messages from the hypervisor to the guest. > > Currently both call qemu_get_timedate() directly, but we want to change > that so we can properly handle the various -rtc options. In preparation, > create a helper function to return the virtual RTC time. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr_events.c | 2 +- > hw/ppc/spapr_rtc.c | 12 ++++++++++-- > include/hw/ppc/spapr.h | 1 + > 3 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c > index 1b6157d..80c0266 100644 > --- a/hw/ppc/spapr_events.c > +++ b/hw/ppc/spapr_events.c > @@ -246,7 +246,7 @@ static void spapr_powerdown_req(Notifier *n, void *opaque) > maina->hdr.section_id = cpu_to_be16(RTAS_LOG_V6_SECTION_ID_MAINA); > maina->hdr.section_length = cpu_to_be16(sizeof(*maina)); > /* FIXME: section version, subtype and creator id? */ > - qemu_get_timedate(&tm, spapr->rtc_offset); > + spapr_rtc_read(spapr, &tm, NULL); > year = tm.tm_year + 1900; > maina->creation_date = cpu_to_be32((to_bcd(year / 100) << 24) > | (to_bcd(year % 100) << 16) > diff --git a/hw/ppc/spapr_rtc.c b/hw/ppc/spapr_rtc.c > index e290ac0..9ccefbc 100644 > --- a/hw/ppc/spapr_rtc.c > +++ b/hw/ppc/spapr_rtc.c > @@ -29,19 +29,27 @@ > #include "hw/ppc/spapr.h" > #include "qapi-event.h" > > +void spapr_rtc_read(sPAPREnvironment *spapr, struct tm *tm, uint32_t *ns) > +{ > + qemu_get_timedate(tm, spapr->rtc_offset); > + if (ns) checkpatch? ;) Alex