From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [RFC PATCHv2 1/7] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor Date: Tue, 16 Dec 2014 11:50:32 +0900 Message-ID: <548F9DF8.80508@samsung.com> References: <1418134386-14681-1-git-send-email-cw00.choi@samsung.com> <1418134386-14681-2-git-send-email-cw00.choi@samsung.com> <1418204220.16644.14.camel@AMDC1943> <5488FDCE.2060009@samsung.com> <548A643D.10508@samsung.com> <1418639428.7591.5.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1418639428.7591.5.camel@AMDC1943> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, kgene.kim@samsung.com, linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, tomasz.figa@gmail.com, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, a.kesavan@samsung.com, linux-arm-kernel@lists.infradead.org, b.zolnierkie@samsung.com List-Id: linux-pm@vger.kernel.org SGkgS3J6eXN6dG9mLAoKT24gMTIvMTUvMjAxNCAwNzozMCBQTSwgS3J6eXN6dG9mIEtvemxvd3Nr aSB3cm90ZToKPiBPbiBwacSFLCAyMDE0LTEyLTEyIGF0IDEyOjQyICswOTAwLCBDaGFud29vIENo b2kgd3JvdGU6Cj4+IEhpIEtyenlzenRvZiwKPj4KPj4gSSByZXBsaWVkIGFnYWluIHRoaXMgbWFp bCBiZWNhdXNlIEknbGwgdXNlIHRoZSBtdXRleCBmb3Igc2V0X2V2ZW50KCkvZ2V0X2V2ZW50KCkK Pj4gYWNjb3JkaW5nIHRvIHlvdXIgY29tbWVudC4gQnV0LCBvZl9wYXJzZV9waGFuZGxlKCkgc2Vl bXMgdGhhdCB0aGlzIGZ1bmN0aW9uCj4+IGRvbid0IG5lZWQgdGhlIG9mX25vZGVfcHV0KCkgZnVu Y3Rpb24uCj4+Cj4+Cj4+IE9uIDEyLzExLzIwMTQgMTE6MTMgQU0sIENoYW53b28gQ2hvaSB3cm90 ZToKPj4+IEhpIEtyenlzenRvZiwKPj4+Cj4+PiBGaXJzdCBvZiBhbGwsIHRoYW5rcyBmb3IgeW91 ciByZXZpZXcuCj4+Pgo+Pj4gT24gMTIvMTAvMjAxNCAwNjozNyBQTSwgS3J6eXN6dG9mIEtvemxv d3NraSB3cm90ZToKPj4+PiBPbiB3dG8sIDIwMTQtMTItMDkgYXQgMjM6MTMgKzA5MDAsIENoYW53 b28gQ2hvaSB3cm90ZToKPj4+Pj4gVGhpcyBwYXRjaCBhZGQgbmV3IGRldmZyZXFfZXZlbnQgY2xh c3MgZm9yIGRldmZyZXFfZXZlbnQgZGV2aWNlIHdoaWNoIHByb3ZpZGUKPj4+Pj4gcmF3IGRhdGEg KGUuZy4sIG1lbW9yeSBidXMgdXRpbGl6YXRpb24vR1BVIHV0aWxpemF0aW9uKS4gVGhpcyByYXcg ZGF0YSBmcm9tCj4+Pj4+IGRldmZyZXFfZXZlbnQgZGF0YSB3b3VsZCBiZSB1c2VkIGZvciB0aGUg Z292ZXJub3Igb2YgZGV2ZnJlcSBzdWJzeXN0ZW0uCj4+Pj4+IC0gZGV2ZnJlcV9ldmVudCBkZXZp Y2UgOiBQcm92aWRlIHJhdyBkYXRhIGZvciBnb3Zlcm5vciBvZiBleGlzdGluZyBkZXZmcmVxIGRl dmljZQo+Pj4+PiAtIGRldmZyZXEgZGV2aWNlICAgICAgIDogTW9uaXRvciBkZXZpY2Ugc3RhdGUg YW5kIGNoYW5nZSBmcmVxdWVuY3kvdm9sdGFnZSBvZiBkZXZpY2UKPj4+Pj4gICAgICAgICAgICAg ICAgICAgICAgICAgIHVzaW5nIHRoZSByYXcgZGF0YSBmcm9tIGRldmZyZXFfZXZlbnQgZGV2aWNl Cj4+Pj4+Cj4+Pj4+IFRoZSBkZXZmcmVxIHN1YnN5c3RlbSBzdXBwb3J0IGdlbmVyaWMgRFZGUyhE eW5hbWljIFZvbHRhZ2UvRnJlcXVlbmN5IFNjYWxpbmcpCj4+Pj4+IGZvciBOb24tQ1BVIERldmlj ZXMuIFRoZSBkZXZmcmVxIGRldmljZSB3b3VsZCBkZXJ0ZXJtaW5lIGN1cnJlbnQgZGV2aWNlIHN0 YXRlCj4+Pj4+IHVzaW5nIHZhcmlvdXMgZ292ZXJub3IgKGUuZy4sIG9uZGVtYW5kLCBwZXJmb3Jt YW5jZSwgcG93ZXJzYXZlKS4gQWZ0ZXIgY29tcGxldGVkCj4+Pj4+IGRldGVybWluYXRpb24gb2Yg c3lzdGVtIHN0YXRlLCBkZXZmcmVxIGRldmljZSB3b3VsZCBjaGFuZ2UgdGhlIGZyZXF1ZW5jeS92 b2x0YWdlCj4+Pj4+IG9mIGRldmZyZXEgZGV2aWNlIGFjY29yZGluZyB0byB0aGUgcmVzdWx0IG9m IGdvdmVybm9yLgo+Pj4+Pgo+Pj4+PiBCdXQsIGRldmZyZXEgZ292ZXJub3IgbXVzdCBuZWVkIGJh c2ljIGRhdGEgd2hpY2ggaW5kaWNhdGVzIGN1cnJlbnQgZGV2aWNlIHN0YXRlLgo+Pj4+PiBFeGlz dGluZyBkZXZmcmVxIHN1YnN5c3RlbSBvbmx5IGNvbnNpZGVyIGRldmZyZXEgZGV2aWNlIHdoaWNo IGNoZWNrIGN1cnJlbnQgc3lzdGVtCj4+Pj4+IHN0YXRlIGFuZCBkZXRlcm1pbmUgcHJvcGVyIHN5 c3RlbSBzdGF0ZSB1c2luZyBiYXNpYyBkYXRhLiBUaGVyZSBpcyBubyBzdWJzeXN0ZW0KPj4+Pj4g Zm9yIGRldmljZSBwcm92aWRpbmcgYmFzaWMgZGF0YSB0byBkZXZmcmVxIGRldmljZS4KPj4+Pj4K Pj4+Pj4gVGhlIGRldmZyZXEgc3Vic3lzdGVtIG11c3QgbmVlZCBkZXZmcmVxX2V2ZW50IGRldmlj ZShkYXRhLXByb3ZpZGVyIGRldmljZSkgZm9yCj4+Pj4+IGV4aXN0aW5nIGRldmZyZXEgZGV2aWNl LiBTbywgdGhpcyBwYXRjaCBhZGQgbmV3IGRldmZyZXFfZXZlbnQgY2xhc3MgZm9yCj4+Pj4+IGRl dmZyZXFfZXZlbnQgZGV2aWNlIHdoaWNoIHJlYWQgdmFyaW91cyBiYXNpYyBkYXRhKGUuZywgbWVt b3J5IGJ1cyB1dGlsaXphdGlvbiwKPj4+Pj4gR1BVIHV0aWxpemF0aW9uKSBhbmQgcHJvdmlkZSBt ZWFzdXJlZCBkYXRhIHRvIGV4aXN0aW5nIGRldmZyZXEgZGV2aWNlIHRocm91Z2gKPj4+Pj4gc3Rh bmRhcmQgQVBJcyBvZiBkZXZmcmVxX2V2ZW50IGNsYXNzLgo+Pj4+Pgo+Pj4+PiBUaGUgZm9sbG93 aW5nIGRlc2NyaXB0aW9uIGV4cGxhaW5zIHRoZSBmZWF0dXJlIG9mIHR3byBraW5kIG9mIGRldmZy ZXEgY2xhc3M6Cj4+Pj4+IC0gZGV2ZnJlcSBjbGFzcyAoZXhpc3RpbmcpCj4+Pj4+ICA6IGRldmZy ZXEgY29uc3VtZXIgZGV2aWNlIHVzZSByYXcgZGF0YSBmcm9tIGRldmZyZXFfZXZlbnQgZGV2aWNl IGZvcgo+Pj4+PiAgICBkZXRlcm1pbmluZyBwcm9wZXIgY3VycmVudCBzeXN0ZW0gc3RhdGUgYW5k IGNoYW5nZSB2b2x0YWdlL2ZyZXF1ZW5jeQo+Pj4+PiAgICBkeW5hbWljYWxseSB1c2luZyB2YXJp b3VzIGdvdmVybm9ycy4KPj4+Pj4KPj4+Pj4gLSBkZXZmcmVxX2V2ZW50IGNsYXNzIChuZXcpCj4+ Pj4+ICA6IFByb3ZpZGUgbWVhc3VyZWQgcmF3IGRhdGEgdG8gZGV2ZnJlcSBkZXZpY2UgZm9yIGdv dmVybm9yCj4+Pj4+Cj4+Pj4+IENjOiBNeXVuZ0pvbyBIYW0gPG15dW5nam9vLmhhbUBzYW1zdW5n LmNvbT4KPj4+Pj4gQ2M6IEt5dW5nbWluIFBhcmsgPGt5dW5nbWluLnBhcmtAc2Ftc3VuZy5jb20+ Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IENoYW53b28gQ2hvaSA8Y3cwMC5jaG9pQHNhbXN1bmcuY29t Pgo+Pj4+PiAtLS0KPj4+Pj4gIGRyaXZlcnMvZGV2ZnJlcS9LY29uZmlnICAgICAgICAgfCAgIDIg Kwo+Pj4+PiAgZHJpdmVycy9kZXZmcmVxL01ha2VmaWxlICAgICAgICB8ICAgNSArLQo+Pj4+PiAg ZHJpdmVycy9kZXZmcmVxL2RldmZyZXEtZXZlbnQuYyB8IDMwMiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4+Pj4+ICBkcml2ZXJzL2RldmZyZXEvZXZlbnQvTWFrZWZp bGUgIHwgICAxICsKPj4+Pj4gIGluY2x1ZGUvbGludXgvZGV2ZnJlcS5oICAgICAgICAgfCAxNDEg KysrKysrKysrKysrKysrKysrKwo+Pj4+PiAgNSBmaWxlcyBjaGFuZ2VkLCA0NTAgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQo+Pj4+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZGV2 ZnJlcS9kZXZmcmVxLWV2ZW50LmMKPj4+Pj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2Rl dmZyZXEvZXZlbnQvTWFrZWZpbGUKPj4+Pj4KPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZGV2 ZnJlcS9LY29uZmlnIGIvZHJpdmVycy9kZXZmcmVxL0tjb25maWcKPj4+Pj4gaW5kZXggZmFmNGU3 MC4uNGQxNWI2MiAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9kZXZmcmVxL0tjb25maWcKPj4+ Pj4gKysrIGIvZHJpdmVycy9kZXZmcmVxL0tjb25maWcKPj4+Pj4gQEAgLTg3LDQgKzg3LDYgQEAg Y29uZmlnIEFSTV9FWFlOT1M1X0JVU19ERVZGUkVRCj4+Pj4+ICAJICBJdCByZWFkcyBQUE1VIGNv dW50ZXJzIG9mIG1lbW9yeSBjb250cm9sbGVycyBhbmQgYWRqdXN0cyB0aGUKPj4+Pj4gIAkgIG9w ZXJhdGluZyBmcmVxdWVuY2llcyBhbmQgdm9sdGFnZXMgd2l0aCBPUFAgc3VwcG9ydC4KPj4+Pj4g IAo+Pj4+PiArY29tbWVudCAiREVWRlJFUSBFdmVudCBEcml2ZXJzIgo+Pj4+PiArCj4+Pj4+ICBl bmRpZiAjIFBNX0RFVkZSRVEKPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZGV2ZnJlcS9NYWtl ZmlsZSBiL2RyaXZlcnMvZGV2ZnJlcS9NYWtlZmlsZQo+Pj4+PiBpbmRleCAxNjEzOGM5Li5hMWZm YWJlIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2RldmZyZXEvTWFrZWZpbGUKPj4+Pj4gKysr IGIvZHJpdmVycy9kZXZmcmVxL01ha2VmaWxlCj4+Pj4+IEBAIC0xLDQgKzEsNCBAQAo+Pj4+PiAt b2JqLSQoQ09ORklHX1BNX0RFVkZSRVEpCSs9IGRldmZyZXEubwo+Pj4+PiArb2JqLSQoQ09ORklH X1BNX0RFVkZSRVEpCQkrPSBkZXZmcmVxLm8gZGV2ZnJlcS1ldmVudC5vCj4+Pj4+ICBvYmotJChD T05GSUdfREVWRlJFUV9HT1ZfU0lNUExFX09OREVNQU5EKQkrPSBnb3Zlcm5vcl9zaW1wbGVvbmRl bWFuZC5vCj4+Pj4+ICBvYmotJChDT05GSUdfREVWRlJFUV9HT1ZfUEVSRk9STUFOQ0UpCSs9IGdv dmVybm9yX3BlcmZvcm1hbmNlLm8KPj4+Pj4gIG9iai0kKENPTkZJR19ERVZGUkVRX0dPVl9QT1dF UlNBVkUpCSs9IGdvdmVybm9yX3Bvd2Vyc2F2ZS5vCj4+Pj4+IEBAIC03LDMgKzcsNiBAQCBvYmot JChDT05GSUdfREVWRlJFUV9HT1ZfVVNFUlNQQUNFKQkrPSBnb3Zlcm5vcl91c2Vyc3BhY2Uubwo+ Pj4+PiAgIyBERVZGUkVRIERyaXZlcnMKPj4+Pj4gIG9iai0kKENPTkZJR19BUk1fRVhZTk9TNF9C VVNfREVWRlJFUSkJKz0gZXh5bm9zLwo+Pj4+PiAgb2JqLSQoQ09ORklHX0FSTV9FWFlOT1M1X0JV U19ERVZGUkVRKQkrPSBleHlub3MvCj4+Pj4+ICsKPj4+Pj4gKyMgREVWRlJFUSBFdmVudCBEcml2 ZXJzCj4+Pj4+ICtvYmotJChDT05GSUdfUE1fREVWRlJFUSkJCSs9IGV2ZW50Lwo+Pj4+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9kZXZmcmVxL2RldmZyZXEtZXZlbnQuYyBiL2RyaXZlcnMvZGV2ZnJl cS9kZXZmcmVxLWV2ZW50LmMKPj4+Pj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPj4+Pj4gaW5kZXgg MDAwMDAwMC4uYjQ3MzI5Zgo+Pj4+PiAtLS0gL2Rldi9udWxsCj4+Pj4+ICsrKyBiL2RyaXZlcnMv ZGV2ZnJlcS9kZXZmcmVxLWV2ZW50LmMKPj4+Pj4gQEAgLTAsMCArMSwzMDIgQEAKPj4+Pj4gKy8q Cj4+Pj4+ICsgKiBkZXZmcmVxLWV2ZW50OiBHZW5lcmljIERFVkZSRVEgRXZlbnQgY2xhc3MgZHJp dmVyCj4+Pj4+ICsgKgo+Pj4+PiArICogQ29weXJpZ2h0IChDKSAyMDE0IFNhbXN1bmcgRWxlY3Ry b25pY3MKPj4+Pj4gKyAqIENoYW53b28gQ2hvaSA8Y3cwMC5jaG9pQHNhbXN1bmcuY29tPgo+Pj4+ PiArICoKPj4+Pj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Cj4+Pj4+ICsgKiBpdCB1bmRlciB0aGUgdGVybXMg b2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMiBhcwo+Pj4+PiArICog cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24uCj4+Pj4+ICsgKgo+Pj4+ PiArICogVGhpcyBkcml2ZXIgaXMgYmFzZWQgb24gZHJpdmVycy9kZXZmcmVxL2RldmZyZXEuYwo+ Pj4+PiArICovCj4+Pj4+ICsKPj4+Pj4gKyNpbmNsdWRlIDxsaW51eC9rZXJuZWwuaD4KPj4+Pj4g KyNpbmNsdWRlIDxsaW51eC9zY2hlZC5oPgo+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L2Vycm5vLmg+ Cj4+Pj4+ICsjaW5jbHVkZSA8bGludXgvZXJyLmg+Cj4+Pj4+ICsjaW5jbHVkZSA8bGludXgvaW5p dC5oPgo+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+Pj4+PiArI2luY2x1ZGUgPGxp bnV4L3NsYWIuaD4KPj4+Pj4gKyNpbmNsdWRlIDxsaW51eC9zdGF0Lmg+Cj4+Pj4+ICsjaW5jbHVk ZSA8bGludXgvcG1fb3BwLmg+Cj4+Pj4+ICsjaW5jbHVkZSA8bGludXgvZGV2ZnJlcS5oPgo+Pj4+ PiArI2luY2x1ZGUgPGxpbnV4L3dvcmtxdWV1ZS5oPgo+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L3Bs YXRmb3JtX2RldmljZS5oPgo+Pj4+PiArI2luY2x1ZGUgPGxpbnV4L2xpc3QuaD4KPj4+Pj4gKyNp bmNsdWRlIDxsaW51eC9wcmludGsuaD4KPj4+Pj4gKyNpbmNsdWRlIDxsaW51eC9ocnRpbWVyLmg+ Cj4+Pj4+ICsjaW5jbHVkZSA8bGludXgvb2YuaD4KPj4+Pj4gKyNpbmNsdWRlICJnb3Zlcm5vci5o Igo+Pj4+PiArCj4+Pj4+ICtzdGF0aWMgc3RydWN0IGNsYXNzICpkZXZmcmVxX2V2ZW50X2NsYXNz Owo+Pj4+PiArCj4+Pj4+ICsvKiBUaGUgbGlzdCBvZiBhbGwgZGV2ZnJlcSBldmVudCBsaXN0ICov Cj4+Pj4+ICtzdGF0aWMgTElTVF9IRUFEKGRldmZyZXFfZXZlbnRfbGlzdCk7Cj4+Pj4+ICtzdGF0 aWMgREVGSU5FX01VVEVYKGRldmZyZXFfZXZlbnRfbGlzdF9sb2NrKTsKPj4+Pj4gKwo+Pj4+PiAr I2RlZmluZSB0b19kZXZmcmVxX2V2ZW50KERFVikgY29udGFpbmVyX29mKERFViwgc3RydWN0IGRl dmZyZXFfZXZlbnRfZGV2LCBkZXYpCj4+Pj4+ICsKPj4+Pj4gK3N0cnVjdCBkZXZmcmVxX2V2ZW50 X2RldiAqZGV2ZnJlcV9hZGRfZXZlbnRfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKmRldiwKPj4+Pj4g KwkJCQkJc3RydWN0IGRldmZyZXFfZXZlbnRfZGVzYyAqZGVzYykKPj4+Pj4gK3sKPj4+Pj4gKwlz dHJ1Y3QgZGV2ZnJlcV9ldmVudF9kZXYgKmV2ZW50X2RldjsKPj4+Pj4gKwlzdGF0aWMgYXRvbWlj X3QgZXZlbnRfbm8gPSBBVE9NSUNfSU5JVCgwKTsKPj4+Pj4gKwlpbnQgcmV0Owo+Pj4+PiArCj4+ Pj4+ICsJaWYgKCFkZXYgfHwgIWRlc2MpCj4+Pj4+ICsJCXJldHVybiBFUlJfUFRSKC1FSU5WQUwp Owo+Pj4+PiArCj4+Pj4+ICsJaWYgKCFkZXNjLT5uYW1lIHx8ICFkZXNjLT5vcHMpCj4+Pj4+ICsJ CXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+Pj4+PiArCj4+Pj4+ICsJZXZlbnRfZGV2ID0ga3ph bGxvYyhzaXplb2Yoc3RydWN0IGRldmZyZXFfZXZlbnRfZGV2KSwgR0ZQX0tFUk5FTCk7Cj4+Pj4+ ICsJaWYgKCFldmVudF9kZXYpCj4+Pj4+ICsJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwo+Pj4+ Cj4+Pj4gSXMgdGhpcyBtZW1vcnkgZnJlZWQgYW55d2hlcmUgd2hlbiBkcml2ZXIgaXMgcmVtb3Zl ZD8gSSBjb3VsZG4ndCBmaW5kCj4+Pj4gaXQuIEkgY291bGRuJ3QgYWxzbyBmaW5kIGZ1bmN0aW9u IGxpa2UgZGV2ZnJlcV9yZW1vdmVfZXZlbnRfZGV2aWNlKCkKPj4+PiB3aGljaCB3b3VsZCBiZSBy ZXZlcnRpbmcgYWxsIHRoZSB3b3JrIGRvbmUgd2hlbiBhZGRpbmcuCj4+Pgo+Pj4gWW91J3JlIHJp Z2h0LiBJJ2xsIHVzZSBkZXZtX2t6YWxsb2MgaW5zdGVhZCBvZiBremFsbG9jLgo+Pj4KPj4+Pgo+ Pj4+PiArCj4+Pj4+ICsJbXV0ZXhfbG9jaygmZGV2ZnJlcV9ldmVudF9saXN0X2xvY2spOwo+Pj4+ PiArCj4+Pj4+ICsJbXV0ZXhfaW5pdCgmZXZlbnRfZGV2LT5sb2NrKTsKPj4+Pj4gKwlldmVudF9k ZXYtPmRlc2MgPSBkZXNjOwo+Pj4+PiArCWV2ZW50X2Rldi0+ZGV2LnBhcmVudCA9IGRldjsKPj4+ Pj4gKwlldmVudF9kZXYtPmRldi5jbGFzcyA9IGRldmZyZXFfZXZlbnRfY2xhc3M7Cj4+Pj4+ICsK Pj4+Pj4gKwlkZXZfc2V0X25hbWUoJmV2ZW50X2Rldi0+ZGV2LCAiZXZlbnQuJWQiLAo+Pj4+PiAr CQkgICAgIGF0b21pY19pbmNfcmV0dXJuKCZldmVudF9ubykgLSAxKTsKPj4+Pj4gKwlyZXQgPSBk ZXZpY2VfcmVnaXN0ZXIoJmV2ZW50X2Rldi0+ZGV2KTsKPj4+Pj4gKwlpZiAocmV0ICE9IDApIHsK Pj4+Pj4gKwkJcHV0X2RldmljZSgmZXZlbnRfZGV2LT5kZXYpOwo+Pj4+PiArCQlnb3RvIGVycjsK Pj4+Pj4gKwl9Cj4+Pj4+ICsJZGV2X3NldF9kcnZkYXRhKCZldmVudF9kZXYtPmRldiwgZXZlbnRf ZGV2KTsKPj4+Pj4gKwo+Pj4+PiArCS8qIEFkZCBkZXZmcmVxIGV2ZW50IGRldmljZSB0byBkZXZm cmVxX2V2ZW50X2xpc3QgKi8KPj4+Pj4gKwlJTklUX0xJU1RfSEVBRCgmZXZlbnRfZGV2LT5ub2Rl KTsKPj4+Pj4gKwlsaXN0X2FkZCgmZXZlbnRfZGV2LT5ub2RlLCAmZGV2ZnJlcV9ldmVudF9saXN0 KTsKPj4+Pj4gKwo+Pj4+PiArCW11dGV4X3VubG9jaygmZGV2ZnJlcV9ldmVudF9saXN0X2xvY2sp Owo+Pj4+PiArCj4+Pj4+ICsJcmV0dXJuIGV2ZW50X2RldjsKPj4+Pj4gK2VycjoKPj4+Pgo+Pj4+ IE1pc3NpbmcgJ211dGV4X3VubG9jaygmZGV2ZnJlcV9ldmVudF9saXN0X2xvY2spJyBoZXJlLgo+ Pj4KPj4+IE9LLiBJJ2xsIGZpeCBpdC4KPj4+Cj4+Pj4KPj4+Pgo+Pj4+PiArCWtmcmVlKGV2ZW50 X2Rldik7Cj4+Pj4+ICsJcmV0dXJuIEVSUl9QVFIocmV0KTsKPj4+Pj4gK30KPj4+Pj4gK0VYUE9S VF9TWU1CT0woZGV2ZnJlcV9hZGRfZXZlbnRfZGV2aWNlKTsKPj4+Pj4gKwo+Pj4+PiArc3RydWN0 IGRldmZyZXFfZXZlbnRfZGV2ICpkZXZmcmVxX2dldF9ldmVudF9kZXYoY29uc3QgY2hhciAqZXZl bnRfZGV2X25hbWUpCj4+Pj4+ICt7Cj4+Pj4+ICsJc3RydWN0IGRldmZyZXFfZXZlbnRfZGV2ICpl dmVudF9kZXY7Cj4+Pj4+ICsKPj4+Pj4gKwltdXRleF9sb2NrKCZkZXZmcmVxX2V2ZW50X2xpc3Rf bG9jayk7Cj4+Pj4+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeShldmVudF9kZXYsICZkZXZmcmVxX2V2 ZW50X2xpc3QsIG5vZGUpIHsKPj4+Pj4gKwkJaWYgKCFzdHJjbXAoZXZlbnRfZGV2LT5kZXNjLT5u YW1lLCBldmVudF9kZXZfbmFtZSkpCj4+Pj4+ICsJCQlnb3RvIG91dDsKPj4+Pj4gKwl9Cj4+Pj4+ ICsJZXZlbnRfZGV2ID0gTlVMTDsKPj4+Pj4gK291dDoKPj4+Pj4gKwltdXRleF91bmxvY2soJmRl dmZyZXFfZXZlbnRfbGlzdF9sb2NrKTsKPj4+Pj4gKwo+Pj4+PiArCXJldHVybiBldmVudF9kZXY7 Cj4+Pj4+ICt9Cj4+Pj4+ICtFWFBPUlRfU1lNQk9MX0dQTChkZXZmcmVxX2dldF9ldmVudF9kZXYp Owo+Pj4+PiArCj4+Pj4+ICtzdHJ1Y3QgZGV2ZnJlcV9ldmVudF9kZXYgKmRldmZyZXFfZ2V0X2V2 ZW50X2Rldl9ieV9waGFuZGxlKHN0cnVjdCBkZXZpY2UgKmRldiwKPj4+Pj4gKwkJCQkJCSAgICAg IGludCBpbmRleCkKPj4+Pj4gK3sKPj4+Pj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5vZGU7Cj4+ Pj4+ICsJc3RydWN0IGRldmZyZXFfZXZlbnRfZGV2ICpldmVudF9kZXY7Cj4+Pj4+ICsKPj4+Pj4g KwlpZiAoIWRldi0+b2Zfbm9kZSkgewo+Pj4+PiArCQlkZXZfZXJyKGRldiwgImRldmljZSBkb2Vz IG5vdCBoYXZlIGEgZGV2aWNlIG5vZGUgZW50cnlcbiIpOwo+Pj4+PiArCQlyZXR1cm4gRVJSX1BU UigtRUlOVkFMKTsKPj4+Pj4gKwl9Cj4+Pj4+ICsKPj4+Pj4gKwlub2RlID0gb2ZfcGFyc2VfcGhh bmRsZShkZXYtPm9mX25vZGUsICJkZXZmcmVxLWV2ZW50cyIsIGluZGV4KTsKPj4+Pj4gKwlpZiAo IW5vZGUpIHsKPj4+Pj4gKwkJZGV2X2VycihkZXYsICJmYWlsZWQgdG8gZ2V0IHBoYW5kbGUgaW4g JXMgbm9kZVxuIiwKPj4+Pj4gKwkJCWRldi0+b2Zfbm9kZS0+ZnVsbF9uYW1lKTsKPj4+Pj4gKwkJ cmV0dXJuIEVSUl9QVFIoLUVOT0RFVik7Cj4+Pj4+ICsJfQo+Pj4+PiArCj4+Pj4+ICsJZXZlbnRf ZGV2ID0gZGV2ZnJlcV9nZXRfZXZlbnRfZGV2KG5vZGUtPm5hbWUpOwo+Pj4+PiArCWlmICghZXZl bnRfZGV2KSB7Cj4+Pj4+ICsJCWRldl9lcnIoZGV2LCAidW5hYmxlIHRvIGdldCBkZXZmcmVxLWV2 ZW50IGRldmljZSA6ICVzXG4iLAo+Pj4+PiArCQkJbm9kZS0+bmFtZSk7Cj4+Pj4KPj4+PiBvZl9u b2RlX3B1dCgpIGZvciBub2RlIG9idGFpbmVkIHdpdGggb2ZfcGFyc2VfcGhhbmRsZSgpLgo+Pj4K Pj4+IE9LLiBJJ2xsIGFkZCBpdC4KPj4KPj4gb2ZfcGFyc2VfcGhhbmRsZSgpIHNlZW1zIHRoYXQg aXQgZG9uJ3QgbmVlZCBvZl9ub2RlX3B1dCgpLgo+IAo+IFRoZSBvZl9wYXJzZV9waGFuZGxlKCkg aW5jcmVhc2VzIHRoZSByZWZjb3VudCBmb3Igbm9kZSBpdCByZXR1cm5zLgo+PkZyb20gZG9jdW1l bnRhdGlvbjoKPiAKPiAvKioKPiAgKiBSZXR1cm5zIHRoZSBkZXZpY2Vfbm9kZSBwb2ludGVyIHdp dGggcmVmY291bnQgaW5jcmVtZW50ZWQuICBVc2UKPiAgKiBvZl9ub2RlX3B1dCgpIG9uIGl0IHdo ZW4gZG9uZS4KPiAgKi8KPiAKPiBUaGUgZnVuY3Rpb24gcmV0dXJucyBlcnJvciBjb25kaXRpb24g YnV0IG5vZGUgd2FzIGZvdW5kIGFuZCBpdHMgcmVmY250Cj4gd2FzIGluY3JlbWVudGVkLiBUaGVu IHdoeSBkbyB5b3UgdGhpbmsgdGhhdCBvZl9ub2RlX3B1dCgpIGlzIG5vdAo+IG5lY2Vzc2FyeSBo ZXJlPwoKT0ssIEknbGwgY2FsbCBvZl9ub2RlX3B1dCgpIGFzIGZvbGxvd2luZzoKCmRpZmYgLS1n aXQgYS9kcml2ZXJzL2RldmZyZXEvZGV2ZnJlcS1ldmVudC5jIGIvZHJpdmVycy9kZXZmcmVxL2Rl dmZyZXEtZXZlbnQuYwppbmRleCBjZDljNDg1Li5hMWVkYWZjIDEwMDY0NAotLS0gYS9kcml2ZXJz L2RldmZyZXEvZGV2ZnJlcS1ldmVudC5jCisrKyBiL2RyaXZlcnMvZGV2ZnJlcS9kZXZmcmVxLWV2 ZW50LmMKQEAgLTI4Miw5ICsyODIsMTIgQEAgb3V0OgogICAgICAgIGlmICghZWRldikgewogICAg ICAgICAgICAgICAgZGV2X2VycihkZXYsICJ1bmFibGUgdG8gZ2V0IGRldmZyZXEtZXZlbnQgZGV2 aWNlIDogJXNcbiIsCiAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUtPm5hbWUpOworICAgICAg ICAgICAgICAgb2Zfbm9kZV9wdXQobm9kZSk7CiAgICAgICAgICAgICAgICByZXR1cm4gRVJSX1BU UigtRU5PREVWKTsKICAgICAgICB9CiAKKyAgICAgICBvZl9ub2RlX3B1dChub2RlKTsKKwogICAg ICAgIHJldHVybiBlZGV2OwogfQoKPiAKPj4KPj4+Cj4+Pj4KPj4+Pj4gKwkJcmV0dXJuIEVSUl9Q VFIoLUVOT0RFVik7Cj4+Pj4+ICsJfQo+Pj4+PiArCj4+Pj4+ICsJcmV0dXJuIGV2ZW50X2RldjsK Pj4+Pj4gK30KPj4+Pj4gK0VYUE9SVF9TWU1CT0xfR1BMKGRldmZyZXFfZ2V0X2V2ZW50X2Rldl9i eV9waGFuZGxlKTsKPj4+Pj4gKwo+Pj4+PiAraW50IGRldmZyZXFfcHV0X2V2ZW50X2RldihzdHJ1 Y3QgZGV2ZnJlcV9ldmVudF9kZXYgKmV2ZW50X2RldikKPj4+Pj4gK3sKPj4+Pgo+Pj4+IG9mX25v ZGVfcHV0KCkgaGVyZSB0byBkZWNyZW1lbnQgcmVmY250IGZyb20gb2ZfcGFyc2VfcGhhbmRsZSgp Pwo+Pj4KPj4+IEl0IGlzIG15IG1pc3Rha2UuIEkgdGhpbmsgdGhhdCBkZXZmcmVxX3B1dF9ldmVu dF9kZXYgaXMgbm90IG5lY2Vzc3NhcnkuCj4+PiBJJ2xsIHJlbW92ZSBpdC4KPiAKPiBUaGVuIGhv dyB0byBkZWNyZWFzZSB0aGUgcmVmY250IGZvciBub2RlIG9idGFpbmVkIGluCj4gZGV2ZnJlcV9n ZXRfZXZlbnRfZGV2X2J5X3BoYW5kbGUoKT8KCkknbGwgY2FsbCBvZl9ub2RlX3B1dCBpbiBkZXZm cmVxX2V2ZW50X2dldF9lZGV2X2J5X3BoYW5kbGUoKSBhY2NvcmRpbmcgdG8geW91ciBjb21tZW50 LgoKVGhhbmtzIGZvciB5b3VyIHJldmlldy4KCkJlc3QgUmVnYXJkcywKQ2hhbndvbyBDaG9pCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Tue, 16 Dec 2014 11:50:32 +0900 Subject: [RFC PATCHv2 1/7] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor In-Reply-To: <1418639428.7591.5.camel@AMDC1943> References: <1418134386-14681-1-git-send-email-cw00.choi@samsung.com> <1418134386-14681-2-git-send-email-cw00.choi@samsung.com> <1418204220.16644.14.camel@AMDC1943> <5488FDCE.2060009@samsung.com> <548A643D.10508@samsung.com> <1418639428.7591.5.camel@AMDC1943> Message-ID: <548F9DF8.80508@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On 12/15/2014 07:30 PM, Krzysztof Kozlowski wrote: > On pi?, 2014-12-12 at 12:42 +0900, Chanwoo Choi wrote: >> Hi Krzysztof, >> >> I replied again this mail because I'll use the mutex for set_event()/get_event() >> according to your comment. But, of_parse_phandle() seems that this function >> don't need the of_node_put() function. >> >> >> On 12/11/2014 11:13 AM, Chanwoo Choi wrote: >>> Hi Krzysztof, >>> >>> First of all, thanks for your review. >>> >>> On 12/10/2014 06:37 PM, Krzysztof Kozlowski wrote: >>>> On wto, 2014-12-09 at 23:13 +0900, Chanwoo Choi wrote: >>>>> This patch add new devfreq_event class for devfreq_event device which provide >>>>> raw data (e.g., memory bus utilization/GPU utilization). This raw data from >>>>> devfreq_event data would be used for the governor of devfreq subsystem. >>>>> - devfreq_event device : Provide raw data for governor of existing devfreq device >>>>> - devfreq device : Monitor device state and change frequency/voltage of device >>>>> using the raw data from devfreq_event device >>>>> >>>>> The devfreq subsystem support generic DVFS(Dynamic Voltage/Frequency Scaling) >>>>> for Non-CPU Devices. The devfreq device would dertermine current device state >>>>> using various governor (e.g., ondemand, performance, powersave). After completed >>>>> determination of system state, devfreq device would change the frequency/voltage >>>>> of devfreq device according to the result of governor. >>>>> >>>>> But, devfreq governor must need basic data which indicates current device state. >>>>> Existing devfreq subsystem only consider devfreq device which check current system >>>>> state and determine proper system state using basic data. There is no subsystem >>>>> for device providing basic data to devfreq device. >>>>> >>>>> The devfreq subsystem must need devfreq_event device(data-provider device) for >>>>> existing devfreq device. So, this patch add new devfreq_event class for >>>>> devfreq_event device which read various basic data(e.g, memory bus utilization, >>>>> GPU utilization) and provide measured data to existing devfreq device through >>>>> standard APIs of devfreq_event class. >>>>> >>>>> The following description explains the feature of two kind of devfreq class: >>>>> - devfreq class (existing) >>>>> : devfreq consumer device use raw data from devfreq_event device for >>>>> determining proper current system state and change voltage/frequency >>>>> dynamically using various governors. >>>>> >>>>> - devfreq_event class (new) >>>>> : Provide measured raw data to devfreq device for governor >>>>> >>>>> Cc: MyungJoo Ham >>>>> Cc: Kyungmin Park >>>>> Signed-off-by: Chanwoo Choi >>>>> --- >>>>> drivers/devfreq/Kconfig | 2 + >>>>> drivers/devfreq/Makefile | 5 +- >>>>> drivers/devfreq/devfreq-event.c | 302 ++++++++++++++++++++++++++++++++++++++++ >>>>> drivers/devfreq/event/Makefile | 1 + >>>>> include/linux/devfreq.h | 141 +++++++++++++++++++ >>>>> 5 files changed, 450 insertions(+), 1 deletion(-) >>>>> create mode 100644 drivers/devfreq/devfreq-event.c >>>>> create mode 100644 drivers/devfreq/event/Makefile >>>>> >>>>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>>>> index faf4e70..4d15b62 100644 >>>>> --- a/drivers/devfreq/Kconfig >>>>> +++ b/drivers/devfreq/Kconfig >>>>> @@ -87,4 +87,6 @@ config ARM_EXYNOS5_BUS_DEVFREQ >>>>> It reads PPMU counters of memory controllers and adjusts the >>>>> operating frequencies and voltages with OPP support. >>>>> >>>>> +comment "DEVFREQ Event Drivers" >>>>> + >>>>> endif # PM_DEVFREQ >>>>> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >>>>> index 16138c9..a1ffabe 100644 >>>>> --- a/drivers/devfreq/Makefile >>>>> +++ b/drivers/devfreq/Makefile >>>>> @@ -1,4 +1,4 @@ >>>>> -obj-$(CONFIG_PM_DEVFREQ) += devfreq.o >>>>> +obj-$(CONFIG_PM_DEVFREQ) += devfreq.o devfreq-event.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >>>>> @@ -7,3 +7,6 @@ obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >>>>> # DEVFREQ Drivers >>>>> obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ >>>>> obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ >>>>> + >>>>> +# DEVFREQ Event Drivers >>>>> +obj-$(CONFIG_PM_DEVFREQ) += event/ >>>>> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c >>>>> new file mode 100644 >>>>> index 0000000..b47329f >>>>> --- /dev/null >>>>> +++ b/drivers/devfreq/devfreq-event.c >>>>> @@ -0,0 +1,302 @@ >>>>> +/* >>>>> + * devfreq-event: Generic DEVFREQ Event class driver >>>>> + * >>>>> + * Copyright (C) 2014 Samsung Electronics >>>>> + * Chanwoo Choi >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License version 2 as >>>>> + * published by the Free Software Foundation. >>>>> + * >>>>> + * This driver is based on drivers/devfreq/devfreq.c >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include "governor.h" >>>>> + >>>>> +static struct class *devfreq_event_class; >>>>> + >>>>> +/* The list of all devfreq event list */ >>>>> +static LIST_HEAD(devfreq_event_list); >>>>> +static DEFINE_MUTEX(devfreq_event_list_lock); >>>>> + >>>>> +#define to_devfreq_event(DEV) container_of(DEV, struct devfreq_event_dev, dev) >>>>> + >>>>> +struct devfreq_event_dev *devfreq_add_event_device(struct device *dev, >>>>> + struct devfreq_event_desc *desc) >>>>> +{ >>>>> + struct devfreq_event_dev *event_dev; >>>>> + static atomic_t event_no = ATOMIC_INIT(0); >>>>> + int ret; >>>>> + >>>>> + if (!dev || !desc) >>>>> + return ERR_PTR(-EINVAL); >>>>> + >>>>> + if (!desc->name || !desc->ops) >>>>> + return ERR_PTR(-EINVAL); >>>>> + >>>>> + event_dev = kzalloc(sizeof(struct devfreq_event_dev), GFP_KERNEL); >>>>> + if (!event_dev) >>>>> + return ERR_PTR(-ENOMEM); >>>> >>>> Is this memory freed anywhere when driver is removed? I couldn't find >>>> it. I couldn't also find function like devfreq_remove_event_device() >>>> which would be reverting all the work done when adding. >>> >>> You're right. I'll use devm_kzalloc instead of kzalloc. >>> >>>> >>>>> + >>>>> + mutex_lock(&devfreq_event_list_lock); >>>>> + >>>>> + mutex_init(&event_dev->lock); >>>>> + event_dev->desc = desc; >>>>> + event_dev->dev.parent = dev; >>>>> + event_dev->dev.class = devfreq_event_class; >>>>> + >>>>> + dev_set_name(&event_dev->dev, "event.%d", >>>>> + atomic_inc_return(&event_no) - 1); >>>>> + ret = device_register(&event_dev->dev); >>>>> + if (ret != 0) { >>>>> + put_device(&event_dev->dev); >>>>> + goto err; >>>>> + } >>>>> + dev_set_drvdata(&event_dev->dev, event_dev); >>>>> + >>>>> + /* Add devfreq event device to devfreq_event_list */ >>>>> + INIT_LIST_HEAD(&event_dev->node); >>>>> + list_add(&event_dev->node, &devfreq_event_list); >>>>> + >>>>> + mutex_unlock(&devfreq_event_list_lock); >>>>> + >>>>> + return event_dev; >>>>> +err: >>>> >>>> Missing 'mutex_unlock(&devfreq_event_list_lock)' here. >>> >>> OK. I'll fix it. >>> >>>> >>>> >>>>> + kfree(event_dev); >>>>> + return ERR_PTR(ret); >>>>> +} >>>>> +EXPORT_SYMBOL(devfreq_add_event_device); >>>>> + >>>>> +struct devfreq_event_dev *devfreq_get_event_dev(const char *event_dev_name) >>>>> +{ >>>>> + struct devfreq_event_dev *event_dev; >>>>> + >>>>> + mutex_lock(&devfreq_event_list_lock); >>>>> + list_for_each_entry(event_dev, &devfreq_event_list, node) { >>>>> + if (!strcmp(event_dev->desc->name, event_dev_name)) >>>>> + goto out; >>>>> + } >>>>> + event_dev = NULL; >>>>> +out: >>>>> + mutex_unlock(&devfreq_event_list_lock); >>>>> + >>>>> + return event_dev; >>>>> +} >>>>> +EXPORT_SYMBOL_GPL(devfreq_get_event_dev); >>>>> + >>>>> +struct devfreq_event_dev *devfreq_get_event_dev_by_phandle(struct device *dev, >>>>> + int index) >>>>> +{ >>>>> + struct device_node *node; >>>>> + struct devfreq_event_dev *event_dev; >>>>> + >>>>> + if (!dev->of_node) { >>>>> + dev_err(dev, "device does not have a device node entry\n"); >>>>> + return ERR_PTR(-EINVAL); >>>>> + } >>>>> + >>>>> + node = of_parse_phandle(dev->of_node, "devfreq-events", index); >>>>> + if (!node) { >>>>> + dev_err(dev, "failed to get phandle in %s node\n", >>>>> + dev->of_node->full_name); >>>>> + return ERR_PTR(-ENODEV); >>>>> + } >>>>> + >>>>> + event_dev = devfreq_get_event_dev(node->name); >>>>> + if (!event_dev) { >>>>> + dev_err(dev, "unable to get devfreq-event device : %s\n", >>>>> + node->name); >>>> >>>> of_node_put() for node obtained with of_parse_phandle(). >>> >>> OK. I'll add it. >> >> of_parse_phandle() seems that it don't need of_node_put(). > > The of_parse_phandle() increases the refcount for node it returns. >>>From documentation: > > /** > * Returns the device_node pointer with refcount incremented. Use > * of_node_put() on it when done. > */ > > The function returns error condition but node was found and its refcnt > was incremented. Then why do you think that of_node_put() is not > necessary here? OK, I'll call of_node_put() as following: diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c index cd9c485..a1edafc 100644 --- a/drivers/devfreq/devfreq-event.c +++ b/drivers/devfreq/devfreq-event.c @@ -282,9 +282,12 @@ out: if (!edev) { dev_err(dev, "unable to get devfreq-event device : %s\n", node->name); + of_node_put(node); return ERR_PTR(-ENODEV); } + of_node_put(node); + return edev; } > >> >>> >>>> >>>>> + return ERR_PTR(-ENODEV); >>>>> + } >>>>> + >>>>> + return event_dev; >>>>> +} >>>>> +EXPORT_SYMBOL_GPL(devfreq_get_event_dev_by_phandle); >>>>> + >>>>> +int devfreq_put_event_dev(struct devfreq_event_dev *event_dev) >>>>> +{ >>>> >>>> of_node_put() here to decrement refcnt from of_parse_phandle()? >>> >>> It is my mistake. I think that devfreq_put_event_dev is not necesssary. >>> I'll remove it. > > Then how to decrease the refcnt for node obtained in > devfreq_get_event_dev_by_phandle()? I'll call of_node_put in devfreq_event_get_edev_by_phandle() according to your comment. Thanks for your review. Best Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332AbaLPCyk (ORCPT ); Mon, 15 Dec 2014 21:54:40 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:15891 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752703AbaLPCug (ORCPT ); Mon, 15 Dec 2014 21:50:36 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79ab6d0000046f7-a0-548f9df93a27 Content-transfer-encoding: 8BIT Message-id: <548F9DF8.80508@samsung.com> Date: Tue, 16 Dec 2014 11:50:32 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 To: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, kgene.kim@samsung.com, rafael.j.wysocki@intel.com, a.kesavan@samsung.com, tomasz.figa@gmail.com, b.zolnierkie@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [RFC PATCHv2 1/7] devfreq: event: Add new devfreq_event class to provide basic data for devfreq governor References: <1418134386-14681-1-git-send-email-cw00.choi@samsung.com> <1418134386-14681-2-git-send-email-cw00.choi@samsung.com> <1418204220.16644.14.camel@AMDC1943> <5488FDCE.2060009@samsung.com> <548A643D.10508@samsung.com> <1418639428.7591.5.camel@AMDC1943> In-reply-to: <1418639428.7591.5.camel@AMDC1943> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsWyRsSkQPfn3P4Qg0N/uC0er1nMZLFxxnpW i/lHzrFavH5haNG74CqbxdmmN+wWmx5fY7W4vGsOm8Xn3iOMFjPO72OyuN24gs3i8Yq37Bar dv1hdOD12DnrLrvH4j0vmTw2L6n36NuyitHj8ya5ANYoLpuU1JzMstQifbsEroyT39eyFqyI qNg2rYelgbHfs4uRk0NCwETi7PHVjBC2mMSFe+vZuhi5OIQEljJKtPe1sMIUfTj+jx0iMZ1R 4m3vETaQBK+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+NaPE4w2vGCHqNSQuTv0G ZrMIqErcW3aWCcRmE9CS2P/iBthMUYEwiZXTr7CA2CIChhIHd29nghh6nUnizg2wq4UFyiUe HD0KNkdIoJNJ4tu8RBCbU0Bf4seF82CLJQT+skvce76ADWKZgMS3yYfADpUQkJXYdIAZ4jFJ iYMrbrBMYBSbheSdWQjvzELyzgJG5lWMoqkFyQXFSelFJnrFibnFpXnpesn5uZsYgdF6+t+z CTsY7x2wPsQowMGoxMMbUNgfIsSaWFZcmXuI0RToiInMUqLJ+cCUkFcSb2hsZmRhamJqbGRu aaYkzvta6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsbCBPWjNg8U9VwK2A8EbWmtX1E0 Vy37YFyBnv+EN3kvdFJd7v2ZxpkSnFwdcKho3au7XxOTHS32/LFVm5X0tY27cZeEAF/Jlpe5 Zdy7K002ebEeZ5g0u/VRr5zmj+3uHjcsGRK2r9hTcPPIBe0VUxrO7zjvfnn78fm5S25cX2Eb yvilJ3v2vrtKLMUZiYZazEXFiQA8VSWF0QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xoO7Puf0hBp+/Mlo8XrOYyWLjjPWs FvOPnGO1eP3C0KJ3wVU2i7NNb9gtNj2+xmpxedccNovPvUcYLWac38dkcbtxBZvF4xVv2S1W 7frD6MDrsXPWXXaPxXteMnlsXlLv0bdlFaPH501yAaxRDYw2GamJKalFCql5yfkpmXnptkre wfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUA3KimUJeaUAoUCEouLlfTtME0IDXHTtYBp jND1DQmC6zEyQAMJaxgzTn5fy1qwIqJi27QelgbGfs8uRk4OCQETiQ/H/7FD2GISF+6tZ+ti 5OIQEpjOKPG29wgbSIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/5pR4vGGV4wQ 9RoSF6d+A7NZBFQl7i07ywRiswloSex/cQNspqhAmMTK6VdYQGwRAUOJg7u3M0EMvc4kcecG 2HHCAuUSD44eBZsjJNDJJPFtXiKIzSmgL/HjwnnmCYwCs5CcNwvhvFlIzlvAyLyKUTS1ILmg OCk911CvODG3uDQvXS85P3cTIzgVPJPawbiyweIQowAHoxIPb0Bhf4gQa2JZcWXuIUYJDmYl EV73qUAh3pTEyqrUovz4otKc1OJDjKZAz01klhJNzgemqbySeENjEzMjSyNzQwsjY3MlcV4l +7YQIYH0xJLU7NTUgtQimD4mDk6pBsaOt9PfzTrzaE2RrMHrs4VJz+MvV4bd57V/EnBtZ8cD VdZDqwS6/xd/nMytqCLb037LWDN1xYOiyecPbJosfdkqZEaZpnz2t6wjfyYeznO5o6204ZdT TvDxRQub2tbN/X+q48bsk17tKy1Ws09j1b+zPF5fSn7O3l87nswMumZSL9wl/P25/md/JZbi jERDLeai4kQAsvVaBRsDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 12/15/2014 07:30 PM, Krzysztof Kozlowski wrote: > On pią, 2014-12-12 at 12:42 +0900, Chanwoo Choi wrote: >> Hi Krzysztof, >> >> I replied again this mail because I'll use the mutex for set_event()/get_event() >> according to your comment. But, of_parse_phandle() seems that this function >> don't need the of_node_put() function. >> >> >> On 12/11/2014 11:13 AM, Chanwoo Choi wrote: >>> Hi Krzysztof, >>> >>> First of all, thanks for your review. >>> >>> On 12/10/2014 06:37 PM, Krzysztof Kozlowski wrote: >>>> On wto, 2014-12-09 at 23:13 +0900, Chanwoo Choi wrote: >>>>> This patch add new devfreq_event class for devfreq_event device which provide >>>>> raw data (e.g., memory bus utilization/GPU utilization). This raw data from >>>>> devfreq_event data would be used for the governor of devfreq subsystem. >>>>> - devfreq_event device : Provide raw data for governor of existing devfreq device >>>>> - devfreq device : Monitor device state and change frequency/voltage of device >>>>> using the raw data from devfreq_event device >>>>> >>>>> The devfreq subsystem support generic DVFS(Dynamic Voltage/Frequency Scaling) >>>>> for Non-CPU Devices. The devfreq device would dertermine current device state >>>>> using various governor (e.g., ondemand, performance, powersave). After completed >>>>> determination of system state, devfreq device would change the frequency/voltage >>>>> of devfreq device according to the result of governor. >>>>> >>>>> But, devfreq governor must need basic data which indicates current device state. >>>>> Existing devfreq subsystem only consider devfreq device which check current system >>>>> state and determine proper system state using basic data. There is no subsystem >>>>> for device providing basic data to devfreq device. >>>>> >>>>> The devfreq subsystem must need devfreq_event device(data-provider device) for >>>>> existing devfreq device. So, this patch add new devfreq_event class for >>>>> devfreq_event device which read various basic data(e.g, memory bus utilization, >>>>> GPU utilization) and provide measured data to existing devfreq device through >>>>> standard APIs of devfreq_event class. >>>>> >>>>> The following description explains the feature of two kind of devfreq class: >>>>> - devfreq class (existing) >>>>> : devfreq consumer device use raw data from devfreq_event device for >>>>> determining proper current system state and change voltage/frequency >>>>> dynamically using various governors. >>>>> >>>>> - devfreq_event class (new) >>>>> : Provide measured raw data to devfreq device for governor >>>>> >>>>> Cc: MyungJoo Ham >>>>> Cc: Kyungmin Park >>>>> Signed-off-by: Chanwoo Choi >>>>> --- >>>>> drivers/devfreq/Kconfig | 2 + >>>>> drivers/devfreq/Makefile | 5 +- >>>>> drivers/devfreq/devfreq-event.c | 302 ++++++++++++++++++++++++++++++++++++++++ >>>>> drivers/devfreq/event/Makefile | 1 + >>>>> include/linux/devfreq.h | 141 +++++++++++++++++++ >>>>> 5 files changed, 450 insertions(+), 1 deletion(-) >>>>> create mode 100644 drivers/devfreq/devfreq-event.c >>>>> create mode 100644 drivers/devfreq/event/Makefile >>>>> >>>>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>>>> index faf4e70..4d15b62 100644 >>>>> --- a/drivers/devfreq/Kconfig >>>>> +++ b/drivers/devfreq/Kconfig >>>>> @@ -87,4 +87,6 @@ config ARM_EXYNOS5_BUS_DEVFREQ >>>>> It reads PPMU counters of memory controllers and adjusts the >>>>> operating frequencies and voltages with OPP support. >>>>> >>>>> +comment "DEVFREQ Event Drivers" >>>>> + >>>>> endif # PM_DEVFREQ >>>>> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile >>>>> index 16138c9..a1ffabe 100644 >>>>> --- a/drivers/devfreq/Makefile >>>>> +++ b/drivers/devfreq/Makefile >>>>> @@ -1,4 +1,4 @@ >>>>> -obj-$(CONFIG_PM_DEVFREQ) += devfreq.o >>>>> +obj-$(CONFIG_PM_DEVFREQ) += devfreq.o devfreq-event.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o >>>>> obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o >>>>> @@ -7,3 +7,6 @@ obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o >>>>> # DEVFREQ Drivers >>>>> obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos/ >>>>> obj-$(CONFIG_ARM_EXYNOS5_BUS_DEVFREQ) += exynos/ >>>>> + >>>>> +# DEVFREQ Event Drivers >>>>> +obj-$(CONFIG_PM_DEVFREQ) += event/ >>>>> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c >>>>> new file mode 100644 >>>>> index 0000000..b47329f >>>>> --- /dev/null >>>>> +++ b/drivers/devfreq/devfreq-event.c >>>>> @@ -0,0 +1,302 @@ >>>>> +/* >>>>> + * devfreq-event: Generic DEVFREQ Event class driver >>>>> + * >>>>> + * Copyright (C) 2014 Samsung Electronics >>>>> + * Chanwoo Choi >>>>> + * >>>>> + * This program is free software; you can redistribute it and/or modify >>>>> + * it under the terms of the GNU General Public License version 2 as >>>>> + * published by the Free Software Foundation. >>>>> + * >>>>> + * This driver is based on drivers/devfreq/devfreq.c >>>>> + */ >>>>> + >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include >>>>> +#include "governor.h" >>>>> + >>>>> +static struct class *devfreq_event_class; >>>>> + >>>>> +/* The list of all devfreq event list */ >>>>> +static LIST_HEAD(devfreq_event_list); >>>>> +static DEFINE_MUTEX(devfreq_event_list_lock); >>>>> + >>>>> +#define to_devfreq_event(DEV) container_of(DEV, struct devfreq_event_dev, dev) >>>>> + >>>>> +struct devfreq_event_dev *devfreq_add_event_device(struct device *dev, >>>>> + struct devfreq_event_desc *desc) >>>>> +{ >>>>> + struct devfreq_event_dev *event_dev; >>>>> + static atomic_t event_no = ATOMIC_INIT(0); >>>>> + int ret; >>>>> + >>>>> + if (!dev || !desc) >>>>> + return ERR_PTR(-EINVAL); >>>>> + >>>>> + if (!desc->name || !desc->ops) >>>>> + return ERR_PTR(-EINVAL); >>>>> + >>>>> + event_dev = kzalloc(sizeof(struct devfreq_event_dev), GFP_KERNEL); >>>>> + if (!event_dev) >>>>> + return ERR_PTR(-ENOMEM); >>>> >>>> Is this memory freed anywhere when driver is removed? I couldn't find >>>> it. I couldn't also find function like devfreq_remove_event_device() >>>> which would be reverting all the work done when adding. >>> >>> You're right. I'll use devm_kzalloc instead of kzalloc. >>> >>>> >>>>> + >>>>> + mutex_lock(&devfreq_event_list_lock); >>>>> + >>>>> + mutex_init(&event_dev->lock); >>>>> + event_dev->desc = desc; >>>>> + event_dev->dev.parent = dev; >>>>> + event_dev->dev.class = devfreq_event_class; >>>>> + >>>>> + dev_set_name(&event_dev->dev, "event.%d", >>>>> + atomic_inc_return(&event_no) - 1); >>>>> + ret = device_register(&event_dev->dev); >>>>> + if (ret != 0) { >>>>> + put_device(&event_dev->dev); >>>>> + goto err; >>>>> + } >>>>> + dev_set_drvdata(&event_dev->dev, event_dev); >>>>> + >>>>> + /* Add devfreq event device to devfreq_event_list */ >>>>> + INIT_LIST_HEAD(&event_dev->node); >>>>> + list_add(&event_dev->node, &devfreq_event_list); >>>>> + >>>>> + mutex_unlock(&devfreq_event_list_lock); >>>>> + >>>>> + return event_dev; >>>>> +err: >>>> >>>> Missing 'mutex_unlock(&devfreq_event_list_lock)' here. >>> >>> OK. I'll fix it. >>> >>>> >>>> >>>>> + kfree(event_dev); >>>>> + return ERR_PTR(ret); >>>>> +} >>>>> +EXPORT_SYMBOL(devfreq_add_event_device); >>>>> + >>>>> +struct devfreq_event_dev *devfreq_get_event_dev(const char *event_dev_name) >>>>> +{ >>>>> + struct devfreq_event_dev *event_dev; >>>>> + >>>>> + mutex_lock(&devfreq_event_list_lock); >>>>> + list_for_each_entry(event_dev, &devfreq_event_list, node) { >>>>> + if (!strcmp(event_dev->desc->name, event_dev_name)) >>>>> + goto out; >>>>> + } >>>>> + event_dev = NULL; >>>>> +out: >>>>> + mutex_unlock(&devfreq_event_list_lock); >>>>> + >>>>> + return event_dev; >>>>> +} >>>>> +EXPORT_SYMBOL_GPL(devfreq_get_event_dev); >>>>> + >>>>> +struct devfreq_event_dev *devfreq_get_event_dev_by_phandle(struct device *dev, >>>>> + int index) >>>>> +{ >>>>> + struct device_node *node; >>>>> + struct devfreq_event_dev *event_dev; >>>>> + >>>>> + if (!dev->of_node) { >>>>> + dev_err(dev, "device does not have a device node entry\n"); >>>>> + return ERR_PTR(-EINVAL); >>>>> + } >>>>> + >>>>> + node = of_parse_phandle(dev->of_node, "devfreq-events", index); >>>>> + if (!node) { >>>>> + dev_err(dev, "failed to get phandle in %s node\n", >>>>> + dev->of_node->full_name); >>>>> + return ERR_PTR(-ENODEV); >>>>> + } >>>>> + >>>>> + event_dev = devfreq_get_event_dev(node->name); >>>>> + if (!event_dev) { >>>>> + dev_err(dev, "unable to get devfreq-event device : %s\n", >>>>> + node->name); >>>> >>>> of_node_put() for node obtained with of_parse_phandle(). >>> >>> OK. I'll add it. >> >> of_parse_phandle() seems that it don't need of_node_put(). > > The of_parse_phandle() increases the refcount for node it returns. >>>From documentation: > > /** > * Returns the device_node pointer with refcount incremented. Use > * of_node_put() on it when done. > */ > > The function returns error condition but node was found and its refcnt > was incremented. Then why do you think that of_node_put() is not > necessary here? OK, I'll call of_node_put() as following: diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c index cd9c485..a1edafc 100644 --- a/drivers/devfreq/devfreq-event.c +++ b/drivers/devfreq/devfreq-event.c @@ -282,9 +282,12 @@ out: if (!edev) { dev_err(dev, "unable to get devfreq-event device : %s\n", node->name); + of_node_put(node); return ERR_PTR(-ENODEV); } + of_node_put(node); + return edev; } > >> >>> >>>> >>>>> + return ERR_PTR(-ENODEV); >>>>> + } >>>>> + >>>>> + return event_dev; >>>>> +} >>>>> +EXPORT_SYMBOL_GPL(devfreq_get_event_dev_by_phandle); >>>>> + >>>>> +int devfreq_put_event_dev(struct devfreq_event_dev *event_dev) >>>>> +{ >>>> >>>> of_node_put() here to decrement refcnt from of_parse_phandle()? >>> >>> It is my mistake. I think that devfreq_put_event_dev is not necesssary. >>> I'll remove it. > > Then how to decrease the refcnt for node obtained in > devfreq_get_event_dev_by_phandle()? I'll call of_node_put in devfreq_event_get_edev_by_phandle() according to your comment. Thanks for your review. Best Regards, Chanwoo Choi