From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0r7b-0006vN-UI for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:21:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0r7V-00065Z-RH for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:20:59 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45132 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0r7V-00065V-KK for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:20:53 -0500 Message-ID: <549023A4.8060106@suse.de> Date: Tue, 16 Dec 2014 13:20:52 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1418399932-7658-1-git-send-email-lersek@redhat.com> <1418399932-7658-8-git-send-email-lersek@redhat.com> <54902260.2060105@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image to guest firmware over fw_cfg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Andrew Jones , Laszlo Ersek , QEMU Developers "Richard W.M. Jones" On 16.12.14 13:18, Peter Maydell wrote: > On 16 December 2014 at 12:15, Alexander Graf wrote: >> I don't understand this. On AArch64 I can simply do -kernel Image and it >> boots without decompressing anything, no? > > Yes, but if you pass -kernel Image.gz then it won't work unless the > bootloader (ie QEMU) does the decompression for you. AArch64 differs > from AArch32 here (on 32-bit compressed images have their own builtin > decompressor; on 64-bit this is made the job of the boot loader). > We could choose not to support loading compressed images, but that > would be annoying for users (most other bootloaders do). See > commit 6f5d3cbe88 where we added this support. The patch as is assumes that AArch64 images are always gzipped. I don't think this assumption is correct - if you do "make Image" on a kernel source tree, you will get an uncompressed Image file. I think we'd be better off trying to load it as gzip and if it's not gzipped, fall back to linear load. Alex