From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.g.wood@intel.com>
Received: by yocto-www.yoctoproject.org (Postfix, from userid 118)
	id 7DE72E00928; Tue, 16 Dec 2014 07:29:15 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	yocto-www.yoctoproject.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at
	http://www.dnswl.org/, low *      trust
	*      [209.85.212.174 listed in list.dnswl.org]
	* -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
	*      [score: 0.0000]
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
	[209.85.212.174])
	by yocto-www.yoctoproject.org (Postfix) with ESMTP id 03E00E008F6
	for <toaster@yoctoproject.org>; Tue, 16 Dec 2014 07:29:13 -0800 (PST)
Received: by mail-wi0-f174.google.com with SMTP id h11so12623831wiw.13
	for <toaster@yoctoproject.org>; Tue, 16 Dec 2014 07:29:12 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
	:subject:references:in-reply-to:content-type
	:content-transfer-encoding;
	bh=MLSopqpT3AhCIXY77Nc3dmZI2VqX/S/7plV6Mp/pO1o=;
	b=j5RFILOeGEI8ACVppMAPmldBOa1ixcHf3rI6ZLFwjTp+KJl3Ur4oPSxk64AZmUZRQo
	zAYHNLL/exM37evy+p+lHF5SWuMncgDhNpVXpRswRd0hW+5jXOM8czGN3pLrnl806d1E
	EGIhv80iQ6NJdD+abijMel0ejYDDiMt6h82T41ruRcDOqHq4oSF3DTYSW88dachTtMVa
	mckCwyhhKyygXyJ5Ev/F8MMTFfDl/A/gannbM5QSil2sk63AFgAc2Qg8dg8/9Clg9HWm
	WnTYrGY6rPCbBf3CTipon1LEdK10NsFw5QGY+WV3Q8+h+Wmqo7pz6QB2yUz2tC5lDBEw
	uiYQ==
X-Gm-Message-State: ALoCoQnpJCipn8APvngAQK4Bn2hScEtthXLxJcrS6osFbBoX/JUklCi3mwxAn/S7Ei4E1w5Ux0Eo
X-Received: by 10.194.57.43 with SMTP id f11mr60784122wjq.6.1418743752549;
	Tue, 16 Dec 2014 07:29:12 -0800 (PST)
Received: from [192.168.2.198] ([83.217.123.106])
	by mx.google.com with ESMTPSA id wz5sm1475610wjc.29.2014.12.16.07.29.11
	for <toaster@yoctoproject.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Tue, 16 Dec 2014 07:29:11 -0800 (PST)
Message-ID: <54904FC7.1070700@intel.com>
Date: Tue, 16 Dec 2014 15:29:11 +0000
From: Michael Wood <michael.g.wood@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: toaster@yoctoproject.org
References: <CAJ2CSBuY0wSu0VYbSESSMB4dN8UnEvi_Wff_6=brjr_gKAhKxA@mail.gmail.com>
In-Reply-To: <CAJ2CSBuY0wSu0VYbSESSMB4dN8UnEvi_Wff_6=brjr_gKAhKxA@mail.gmail.com>
Subject: Re: [review-request] adamian/20141215-development
X-BeenThere: toaster@yoctoproject.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: Web based interface for BitBake <toaster.yoctoproject.org>
List-Unsubscribe: <https://lists.yoctoproject.org/options/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=unsubscribe>
List-Archive: <http://lists.yoctoproject.org/pipermail/toaster>
List-Post: <mailto:toaster@yoctoproject.org>
List-Help: <mailto:toaster-request@yoctoproject.org?subject=help>
List-Subscribe: <https://lists.yoctoproject.org/listinfo/toaster>,
	<mailto:toaster-request@yoctoproject.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 15:29:15 -0000
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit

Only one little thing, could we rename "get_actual_commit" to something 
like "get_vcs_reference" as what we're aiming for is the output of the 
function + layer.vcs_url would give you the correct url + reference to 
be able to checkout or recognise the repository with it's associated 
branch/tag/commit.

Thanks,

Michael

On 16/12/14 12:38, Damian, Alexandru wrote:
> This patch changes the build variable setting from in-process 
> injection to a pre-conf file.
>
> Thanks,
> Alex
>
> -- 
> Alex Damian
> Yocto Project
> SSG / OTC
>
>