From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command
Date: Tue, 16 Dec 2014 09:13:36 -0700 [thread overview]
Message-ID: <54905A30.9090307@redhat.com> (raw)
In-Reply-To: <1418725089.9400.40.camel@nilsson.home.kraxel.org>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On 12/16/2014 03:18 AM, Gerd Hoffmann wrote:
> Hi,
>
>>> How does this look like (incremental fixup attached, docs to be
>>> updated) ?
>
>> Might be worth separate docs for the enums (we've done it elsewhere).
>
> Sure, as mentioned above docs where not done yet ...
>
>
>> But the interface looks fine to me.
>
> ... as I wanted to check this first ;)
>
> So, here is the new version with updated docs ;)
Looks okay to me on first glance.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-16 16:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 9:37 [Qemu-devel] [PATCH v2 00/10] vnc: add support for multiple vnc displays Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 01/10] vnc: remove vnc_display global Gerd Hoffmann
2014-12-11 1:58 ` Gonglei
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 02/10] vnc: remove unused DisplayState parameter, add id instead Gerd Hoffmann
2014-12-11 1:59 ` Gonglei
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 03/10] vnc: add display id to acl names Gerd Hoffmann
2014-12-11 2:09 ` Gonglei
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers Gerd Hoffmann
2014-12-11 2:59 ` Gonglei
2014-12-11 8:48 ` Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 05/10] vnc: allow binding servers to qemu consoles Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 06/10] vnc: update docs/multiseat.txt Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 07/10] vnc: track & limit connections Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 08/10] vnc: factor out qmp_query_client_list Gerd Hoffmann
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command Gerd Hoffmann
2014-12-10 16:52 ` Eric Blake
2014-12-11 9:07 ` Gerd Hoffmann
2014-12-11 9:43 ` Daniel P. Berrange
2014-12-11 9:40 ` Daniel P. Berrange
2014-12-11 11:33 ` Gerd Hoffmann
2014-12-11 11:47 ` Daniel P. Berrange
2014-12-15 9:16 ` Gerd Hoffmann
2014-12-15 9:26 ` Daniel P. Berrange
2014-12-15 16:22 ` Eric Blake
2014-12-16 10:18 ` Gerd Hoffmann
2014-12-16 16:13 ` Eric Blake [this message]
2014-12-10 9:37 ` [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets Gerd Hoffmann
2014-12-10 16:54 ` Eric Blake
2014-12-11 9:08 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54905A30.9090307@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.