From: Mike Christie <michaelc@cs.wisc.edu>
To: John Soni Jose <sony.john-n@Emulex.Com>
Cc: linux-scsi@vger.kernel.org, Minh Tran <minhduc.tran@Emulex.Com>,
Jayamohan Kallickal <jayamohan.kallickal@Emulex.Com>
Subject: Re: [PATCH 1/4] be2iscsi : Fix the retry count for boot targets
Date: Tue, 16 Dec 2014 10:53:00 -0600 [thread overview]
Message-ID: <5490636C.5050706@cs.wisc.edu> (raw)
In-Reply-To: <0cb35f54-b286-4416-971f-b0fd9d389ce7@CMEXHTCAS1.ad.emulex.com>
On 12/16/14, 8:33 PM, John Soni Jose wrote:
> +#define GET_BOOT_RETRIES 45
> +#define GET_BOOT_TO 20
> /**
Does beiscsi_get_boot_info() succeed when the fw is able to log into the
target (go into iscsi full feature phase) or just able to reach it (ICMP
ping the port or something like that)? It was not clear why the above
values were selected. Was it meant to detect when the target could be
down for extended periods due to something like maintenance or a reboot,
or is just handling some shorter settle period where the link is up but
the fw could not reach the target port due to needing to do some other
network setup.
Also, I think you want to add some sort of BEISCSI or at least BE prefix
to the names to avoid collisions since they are pretty generic.
next prev parent reply other threads:[~2014-12-16 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 2:33 [PATCH 1/4] be2iscsi : Fix the retry count for boot targets John Soni Jose
2014-12-16 16:53 ` Mike Christie [this message]
2014-12-17 5:21 ` Minh Duc Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5490636C.5050706@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jayamohan.kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
--cc=minhduc.tran@Emulex.Com \
--cc=sony.john-n@Emulex.Com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.