Re: [PATCH] of: i2c: Add DT bindings for idle states to PCA954x mux driver

[Alexander Sverdlin <alexander.sverdlin-OYasijW0DpE@public.gmane.org>]

Hello Laurent!

On 16/12/14 14:38, ext Laurent Pinchart wrote:
>>> I understand the use cases of the idle-disconnect property. What do you
>>> > > use idle-state for, when the idle state is different from disconnecting
>>> > > the bus ?
>> >
>> > We do not have a use case for that. It was done only for the sake of
>> > completeness. Because other MUXes actually offer user this possibility. I
>> > was initially thinking about providing this on i2c-mux level for all of
>> > them, but unfortunately they all use deselect callback in different way and
>> > pinctrl is the worst case, as idle state cannot be represented with an int,
>> > but should be a pointer.
>> > 
>> > Anyway, if you think there is no use-case for this, I can drop this part.
> Adding a DT property without a clear use case usually makes me a bit wary. I 
> would thus prefer going for either idle-disconnect alone, or for an idle-state 
> property that would allow selecting disconnection as one of the possible 
> values.

I thought about this, but this would require some magic value for idle-state
property, which would not be obvious for the readers of .dts file without
consulting the documentation. So, I would prefer to drop the idle channel selection
completely...

-- 
Best regards,
Alexander Sverdlin.