From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/gdb: fix shared-only build
Date: Tue, 16 Dec 2014 21:16:16 +0100 [thread overview]
Message-ID: <54909310.4070306@openwide.fr> (raw)
In-Reply-To: <20141216081322.229c0a52@free-electrons.com>
Hi Thomas,
Le 16/12/2014 08:13, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Sun, 14 Dec 2014 23:47:24 +0100, Romain Naour wrote:
>> When --disable-static is given to the gdb's main configure script,
>> it also disable the static build of bundled libraries like bfd, readline
>> and opcodes, which must be build statically.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/219/21979e730dca1fce5bdda9a4c7fad4485e788866/
>> http://autobuild.buildroot.net/results/c10/c1096d0bd22de5c6feba848f743601ad0416a944/
>> http://autobuild.buildroot.net/results/d8a/d8a5bcc7fa374fb0c916a9d0f33ef283109cb404/
>> http://autobuild.buildroot.net/results/22a/22a86d0f1df0fc4698c0f734f3d659e6317404a4/
>> http://autobuild.buildroot.net/results/404/404e61e5c30040ee5756f4b5839149dca38660d4/
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> ---
>> package/gdb/0001-bfd-force-static-build.patch | 79 +++++++++++++++++++++
>> package/gdb/0002-readline-force-static-build.patch | 34 +++++++++
>> .../gdb/0003-libopcodes-force-static-build.patch | 80 ++++++++++++++++++++++
>> 3 files changed, 193 insertions(+)
>> create mode 100644 package/gdb/0001-bfd-force-static-build.patch
>> create mode 100644 package/gdb/0002-readline-force-static-build.patch
>> create mode 100644 package/gdb/0003-libopcodes-force-static-build.patch
>
> Are you sure patching gdb is the right direction here? I believe those
> patches have no chance to be merged upstream, so patching is not the
> right solution.
Sorry, this patch should have been marked as RFC.
>
> A better solution is probably to re-add --enable-static to
> GDB_CONF_OPTS, even if we're doing a shared only build. This doesn't
> require patching gdb, and is more compliant with what upstream wants:
> doing a pure shared build of gdb isn't supported.
>
Ok, I'm fine with this solution.
I wanted to show what I had done in order to compile gdb in shared only case
without re-add --enable-static in GDB_CONF_OPTS.
I agree patching gdb is not an elegant solution.
What I have observed since shared only build are available, is that some
packages pass --disable-static or disable static build for their build-in
libraries even when they should be build statically :-/
Best regards,
--
Romain Naour
OPEN WIDE Ing?nierie - Paris
23/25, rue Daviel| 75013 PARIS
http://ingenierie.openwide.fr
Le blog des technologies libres et embarqu?es :
http://www.linuxembedded.fr
prev parent reply other threads:[~2014-12-16 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-14 22:47 [Buildroot] [PATCH 1/1] package/gdb: fix shared-only build Romain Naour
2014-12-14 23:17 ` Yann E. MORIN
2014-12-16 7:13 ` Thomas Petazzoni
2014-12-16 20:16 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54909310.4070306@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.