From: Lars-Peter Clausen <lars@metafoo.de>
To: Fabio Estevam <fabio.estevam@freescale.com>, mchehab@osg.samsung.com
Cc: hans.verkuil@cisco.com, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] adv7180: Simplify PM hooks
Date: Tue, 16 Dec 2014 22:20:38 +0100 [thread overview]
Message-ID: <5490A226.1000204@metafoo.de> (raw)
In-Reply-To: <1418748547-12308-1-git-send-email-fabio.estevam@freescale.com>
On 12/16/2014 05:49 PM, Fabio Estevam wrote:
> The macro SIMPLE_DEV_PM_OPS already takes care of the CONFIG_PM_SLEEP=n case.
I guess that's kind of debatable. The purpose of ifdef-ing stuff out is to
decrease the driver size if PM support is disabled. With this change you are
adding a rather large struct which is all NULL to the driver even if PM is
disabled. Previously this was not the case.
prev parent reply other threads:[~2014-12-16 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 16:49 [PATCH 1/2] [media] adv7180: Simplify PM hooks Fabio Estevam
2014-12-16 16:49 ` [PATCH 2/2] [media] adv7180: Remove the unneeded 'err' label Fabio Estevam
2015-01-16 11:30 ` Lars-Peter Clausen
2014-12-16 21:20 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5490A226.1000204@metafoo.de \
--to=lars@metafoo.de \
--cc=fabio.estevam@freescale.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.