From: Gonglei <arei.gonglei@huawei.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/5] bootdevice patches
Date: Wed, 17 Dec 2014 11:27:46 +0800 [thread overview]
Message-ID: <5490F832.4080505@huawei.com> (raw)
In-Reply-To: <CAFEAcA_eUivaxokNYd1TKuE=goBrydgiCW6FZ-6xJArxUXw3-g@mail.gmail.com>
On 2014/12/16 22:01, Peter Maydell wrote:
> On 16 December 2014 at 09:22, <arei.gonglei@huawei.com> wrote:
>> From: root <root@ceth6.(none)>
>>
>> This is my first pull request as a submaintainer. Those patches just
>> move boot order related code to bootdevice.c and add a Error **errp
>> argument for corresponding functions so that it can propagate error messages
>> to the caller. Please pull.
>
> This also seems to cause 'make check' to fail:
>
> TEST: tests/boot-order-test... (pid=16958)
> /i386/boot-order/pc:
> Broken pipe
> FAIL
> GTester: last random seed: R02S5702c094d31af53e45fffabed844705a
> (pid=16973)
> FAIL: tests/boot-order-test
>
Oops, That's because of a typo in patch 2, 'once' -> 'order'.
'make check' should be executed before posting patches :(
I apologize for any inconvenience caused during this process,
and great thanks for your precise job.
Regards,
-Gonglei
next prev parent reply other threads:[~2014-12-17 3:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 9:22 [Qemu-devel] [PULL 0/5] bootdevice patches arei.gonglei
2014-12-16 9:22 ` [Qemu-devel] [PULL 1/5] bootdevice: move code about bootorder from vl.c to bootdevice.c arei.gonglei
2014-12-16 9:22 ` [Qemu-devel] [PULL 2/5] bootdevice: add Error **errp argument for validate_bootdevices() arei.gonglei
2014-12-16 9:22 ` [Qemu-devel] [PULL 3/5] bootdevice: add Error **errp argument for qemu_boot_set() arei.gonglei
2014-12-16 9:22 ` [Qemu-devel] [PULL 4/5] bootdevice: add validate check " arei.gonglei
2014-12-16 9:22 ` [Qemu-devel] [PULL 5/5] bootdevice: add Error **errp argument for QEMUBootSetHandler arei.gonglei
2014-12-16 12:42 ` Peter Maydell
2014-12-16 13:04 ` Gonglei
2014-12-16 13:23 ` Peter Maydell
2014-12-17 3:16 ` Gonglei
2014-12-16 14:01 ` [Qemu-devel] [PULL 0/5] bootdevice patches Peter Maydell
2014-12-17 3:27 ` Gonglei [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-16 10:12 arei.gonglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5490F832.4080505@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.