From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f175.google.com (mail-ig0-f175.google.com [209.85.213.175]) by kanga.kvack.org (Postfix) with ESMTP id CE7F96B0032 for ; Tue, 16 Dec 2014 23:32:32 -0500 (EST) Received: by mail-ig0-f175.google.com with SMTP id h15so8138026igd.8 for ; Tue, 16 Dec 2014 20:32:32 -0800 (PST) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com. [2607:f8b0:4001:c05::235]) by mx.google.com with ESMTPS id h12si2773274ici.1.2014.12.16.20.32.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 16 Dec 2014 20:32:31 -0800 (PST) Received: by mail-ig0-f181.google.com with SMTP id l13so8927129iga.8 for ; Tue, 16 Dec 2014 20:32:31 -0800 (PST) Message-ID: <5491075B.9080609@gmail.com> Date: Tue, 16 Dec 2014 23:32:27 -0500 From: nick MIME-Version: 1.0 Subject: Question about Old Fix Me comment in mempool.c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: akpm@linux-foundation.org Cc: catalin.marinas@arm.com, mpatocka@redhat.com, sebott@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Greetings Andrew and other maintainers, I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now. /* * FIXME: this should be io_schedule(). The timeout is there as a * workaround for some DM problems in 2.6.18. */ Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:). Thanks for Your Time, Nick -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by kanga.kvack.org (Postfix) with ESMTP id ED2B06B0032 for ; Wed, 25 Feb 2015 15:18:52 -0500 (EST) Received: by wghk14 with SMTP id k14so6027296wgh.4 for ; Wed, 25 Feb 2015 12:18:52 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id jj6si31175872wid.41.2015.02.25.12.18.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 12:18:50 -0800 (PST) Date: Wed, 25 Feb 2015 15:18:37 -0500 (EST) From: Mikulas Patocka Subject: Re: Question about Old Fix Me comment in mempool.c In-Reply-To: <5491075B.9080609@gmail.com> Message-ID: References: <5491075B.9080609@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: nick Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, sebott@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, 16 Dec 2014, nick wrote: > Greetings Andrew and other maintainers, > I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now. > /* > * FIXME: this should be io_schedule(). The timeout is there as a > * workaround for some DM problems in 2.6.18. > */ > > Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:). > > Thanks for Your Time, > Nick There are still some bugs with respect to this (and they will probably never be removed all) - for example this bug which wasn't fixed yet http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html . So, you should not remove it. Mikulas -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753543AbbBYUSy (ORCPT ); Wed, 25 Feb 2015 15:18:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54480 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbbBYUSx (ORCPT ); Wed, 25 Feb 2015 15:18:53 -0500 Date: Wed, 25 Feb 2015 15:18:37 -0500 (EST) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: nick cc: akpm@linux-foundation.org, catalin.marinas@arm.com, sebott@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Question about Old Fix Me comment in mempool.c In-Reply-To: <5491075B.9080609@gmail.com> Message-ID: References: <5491075B.9080609@gmail.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Dec 2014, nick wrote: > Greetings Andrew and other maintainers, > I am wondering why the below comment is even in mempool.c and this has not been changed to a call to io_schedule as the kernel version is stupidly old and this should be fixed by now and the issues with DM would have been removed by now. > /* > * FIXME: this should be io_schedule(). The timeout is there as a > * workaround for some DM problems in 2.6.18. > */ > > Sorry for the stupid question but I like to double check with the maintainers before I sent in a patch for things like this to see if I am missing anything:). > > Thanks for Your Time, > Nick There are still some bugs with respect to this (and they will probably never be removed all) - for example this bug which wasn't fixed yet http://www.redhat.com/archives/dm-devel/2014-May/msg00089.html . So, you should not remove it. Mikulas