From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y19lG-0007d1-F9 for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:15:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y19lA-0000O7-7Z for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:15:10 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:14827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y19l9-0000G7-JT for qemu-devel@nongnu.org; Wed, 17 Dec 2014 03:15:04 -0500 Message-ID: <54913B7B.6050803@huawei.com> Date: Wed, 17 Dec 2014 16:14:51 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1418715038-4664-1-git-send-email-zhang.zhanghailiang@huawei.com> <1418715038-4664-3-git-send-email-zhang.zhanghailiang@huawei.com> <2DE29ABD-07C1-4F6B-B826-06FACF87D9F8@redhat.com> <54905D3E.2010704@redhat.com> In-Reply-To: <54905D3E.2010704@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Yan Vugenfirer Cc: hangaohuai@huawei.com, lilei@linux.vnet.ibm.com, qemu-devel , mdroth@linux.vnet.ibm.com, Luiz Capitulino , peter.huangpeng@huawei.com, Laszlo Ersek On 2014/12/17 0:26, Eric Blake wrote: > On 12/16/2014 04:48 AM, Yan Vugenfirer wrote: >>> + >>> + if (si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_AMD64 || >>> + si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_IA64) { >> >> If one of the motivations is to update drivers on the guest - those should be treated as deferent architectures. >> Why not return string as well (x64, x86, IA64, ARM)? > > The architecture should already be known by the host (after all, the > flavor of qemu running the guest should tell you what architecture the > guest would report). > Yes, we can easily get this info from host ;)